Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system test image: build it multiarch #9491

Merged

Conversation

edsantiago
Copy link
Member

buildah now supports running under emulation[1] as well as
creating manifests. Use those features to create a multiarch
testimage that can be used to test podman on other arches.

[1] on Fedora 33, this requires the qemu-user-static package

Signed-off-by: Ed Santiago santiago@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@edsantiago
Copy link
Member Author

I think this is going to fail CI pretty badly. Lots of tests are failing on my laptop, most for reasons I can't even begin to understand. There's something weird about multiarch images. Also, the image is now almost three times its original size (15M, up from 6). This defeats my original purpose of using a tiny image. I can see why there's a docker.io/ARCH/image convention.

I'm going to try to focus on identifying the multiarch problems and seeing if I can fix them. ITM I would welcome advice from the team: should I (a) do that, or (b) forget about multiarch, and just build each arch separately and push it with a different tag, e.g. quay.io/libpod/testimage:YYYYMMDD-{amd64,s390x,etc} ?

@edsantiago
Copy link
Member Author

Weird. CI failed (as expected), but with only one failure (#9493). On my laptop I see many more failures, in networking and image and other tests. I'm starting to think my laptop may be haunted. Anyhow, this PR can't go anywhere until #9493 is resolved.

buildah now supports running under emulation[1] as well as
creating manifests. Use those features to create a multiarch
testimage that can be used to test podman on other arches.

 [1] on Fedora 33, this requires the qemu-user-static package

We also build a new :00000001 image, replacing :00000000,
because (sigh) some tests try to run 'true' in the container.
Include instructions on building said image.

Signed-off-by: Ed Santiago <santiago@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@containers/podman-maintainers PTAL

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit bde1d3f into containers:master Feb 25, 2021
@edsantiago edsantiago deleted the testimage_multiarch branch March 1, 2021 13:46
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants