Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vsomeip3 selinux policy #244

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 12, 2023

This needs to wait until vsomeip3 selinux policy gets corrected and packaged.

@rhatdan
Copy link
Member Author

rhatdan commented Oct 12, 2023

@alexlarsson PTAL

@Yarboa
Copy link
Collaborator

Yarboa commented Oct 12, 2023

This needs to wait until vsomeip3 selinux policy gets corrected and packaged.

@rhatdan is it needed for that manifest?
https://gitlab.com/CentOS/automotive/sample-images/-/merge_requests/377/diffs

@alexlarsson
Copy link
Collaborator

LGTM

@dougsland
Copy link
Collaborator

@rhatdan, CI is getting the output below:

+ export CXX
+ cd qm-0.5.8
+ /usr/bin/make all
mkdir -p tmp; cp qm.* tmp/
make -C tmp -f /usr/share/selinux/devel/Makefile qm.pp
make[1]: Entering directory '/builddir/build/BUILD/qm-0.5.8/tmp'
Compiling targeted qm module
qm.te:3:ERROR 'unknown type vsomeip_t' at token ';' on line 17149:
        allow qm_t vsomeip_t:unix_stream_socket connectto;
#line 3
/usr/bin/checkmodule:  error(s) encountered while parsing configuration
make[1]: *** [/usr/share/selinux/devel/include/Makefile:157: tmp/qm.mod] Error 1
make[1]: Leaving directory '/builddir/build/BUILD/qm-0.5.8/tmp'
make: *** [Makefile:28: qm.pp] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.21stYX (%build)
    Bad exit status from /var/tmp/rpm-tmp.21stYX (%build)

RPM build errors:
Finish: rpmbuild qm-0.5.8-1.20231026200407715281.pr244.51.gf255541.fc39.src.rpm
Finish: build phase for qm-0.5.8-1.20231026200407715281.pr244.51.gf255541.fc39.src.rpm
INFO: chroot_scan: 3 files copied to /var/lib/copr-rpmbuild/results/chroot_scan
INFO: /var/lib/mock/fedora-39-x86_64-1698350693.605672/root/var/log/dnf.rpm.log
/var/lib/mock/fedora-39-x86_64-1698350693.605672/root/var/log/dnf.librepo.log
/var/lib/mock/fedora-39-x86_64-1698350693.605672/root/var/log/dnf.log
ERROR: Exception(/var/lib/copr-rpmbuild/results/qm-0.5.8-1.20231026200407715281.pr244.51.gf255541.fc39.src.rpm) Config(fedora-39-x86_64) 0 minutes 34 seconds
INFO: Results and/or logs in: /var/lib/copr-rpmbuild/results
INFO: Cleaning up build root ('cleanup_on_failure=True')
Start: clean chroot
INFO: unmounting tmpfs.
Finish: clean chroot
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 1d5f341936b14e98a1b0d125f5139a83 -D /var/lib/mock/fedora-39-x86_64-1698350693.605672/root -a -u mockbuild --capability=cap_ipc_lock --rlimit=RLIMIT_NOFILE=10240 --capability=cap_ipc_lock --bind=/tmp/mock-resolv.g96fk4y9:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/mapper/control --bind=/dev/fuse --bind=/dev/loop-control --bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c '/usr/bin/rpmbuild -bb  --target x86_64 --nodeps /builddir/build/originals/qm.spec'

Copr build error: Build failed

@rhatdan
Copy link
Member Author

rhatdan commented Oct 27, 2023

Smooge was supposed to be updating the vsomeip package to be written correctly.

@rhatdan
Copy link
Member Author

rhatdan commented Oct 27, 2023

vsomeip3-3.3.8-1.fc40

@dougsland
Copy link
Collaborator

still not flying, I will try next week a fresh CI/CD job.

@dougsland
Copy link
Collaborator

@rhatdan still failing, anything we should look?

@rhatdan
Copy link
Member Author

rhatdan commented Dec 1, 2023

Ask @smooge about it, looks like vsomeip3-selinux is not packaged centos?

@dougsland
Copy link
Collaborator

For some reason:

No matching package to install: 'vsomeip3-selinux >= 3.3.8'
Not all dependencies satisfied

investigating...

@dougsland
Copy link
Collaborator

@Yarboa just a heads up, I also would like to include this one before the next release. We need to figure out why it's not working, seems not related to the patch but build?

@Yarboa
Copy link
Collaborator

Yarboa commented Jan 9, 2024

@Yarboa just a heads up, I also would like to include this one before the next release. We need to figure out why it's not working, seems not related to the patch but build?

@dougsland Correct, this PR should be rebased inorder to pass tests it is uses qm-0.5.8

@Yarboa just a heads up, I also would like to include this one before the next release. We need to figure out why it's not working, seems not related to the patch but build?

I assume spec file should install epel rpm

%if 0%{?rhel} && 0%{?centos} == 0
# Add EPEL repository for RHEL 9 CentOSStream
Requires: epel-release
%endif
Requires: vsomeip-selinux

@dougsland
Copy link
Collaborator

%if 0%{?rhel} && 0%{?centos} == 0

Add EPEL repository for RHEL 9 CentOSStream

Requires: epel-release
%endif
Requires: vsomeip-selinux

thanks, lets have a try ;-)

@dougsland
Copy link
Collaborator

holy guacamole, not sure if this is a real error, re-triggering the jobs.

[2024-01-09 06:15:30,449][ ERROR][PID:1455460] Re-try request for task on 'ResallocHost, ticket_id=568139, hostname=2620:52:3:1:dead:beef:cafe:c111': Unable to finish after 1 SSH attempts
[2024-01-09 06:15:30,449][  INFO][PID:1455460] Releasing VM back to pool

rpm/qm.spec Outdated Show resolved Hide resolved
rpm/qm.spec Outdated Show resolved Hide resolved
@rhatdan rhatdan requested a review from odra as a code owner January 17, 2024 15:12
@dougsland dougsland force-pushed the selinux branch 2 times, most recently from f6577a3 to e074666 Compare January 17, 2024 15:14
@dougsland
Copy link
Collaborator

CI/CD error raised by pre-commit-checks not related and fixed in another PR:

demos/asilservice:25:1: B036 Don't except `BaseException` unless you plan to re-raise it.

@Yarboa
Copy link
Collaborator

Yarboa commented Jan 17, 2024

CI/CD error raised by pre-commit-checks not related and fixed in another PR:

demos/asilservice:25:1: B036 Don't except `BaseException` unless you plan to re-raise it.

Fixed in #311
The build is related to some thing else,
see PR #298

I need to rebase with #311 and see if solved

rpm/qm.spec Outdated Show resolved Hide resolved
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@dougsland dougsland merged commit d2e1843 into containers:main Jan 17, 2024
2 of 7 checks passed
@dougsland
Copy link
Collaborator

Merged, we fix the packit later on the road. See #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants