Fix again pre-commit dected issues and turn test on for all files #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes missing double quotes introduced in containers#479. Not detected by pre-commit action as it's not configured to run on all files. In tools/qm-storage-settings fix for: for STORAGE_CONF_PATH in ${STORAGE_CONF_PATHS[@]}; do ^----------------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In tools/qm-storage-settings line 52: if [ -f ${STORAGE_CONF_PATH} ]; then ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
odra,
dennisbrendel and
priyverm
as code owners
- always run pre-commit on all files - updated actions solving: ``` The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-python@v4, actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ ``` Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
gh_action_precommit
branch
from
6eb65dc
to
fdabe3f
Compare
odra
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing double quoting in tools/qm-storage-settings
Fixes missing double quotes introduced in #479.
Not detected by pre-commit action as it's not configured to run on all files.
Then, enabling pre-commit on all files preventing this to happen again.