Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added links to llama.cpp REST API documentation #274

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

josiahbryan
Copy link
Contributor

@josiahbryan josiahbryan commented Oct 9, 2024

docs: Added links to llama.cpp REST API documentation and fixed a small spelling error in the readme.

(Submitting PR per @ericcurtin at #265 (comment))

Copy link

We were not able to find or create Copr project packit/containers-ramalama-274 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=containers-ramalama-274 chroots=['centos-stream-9-x86_64', 'centos-stream-10-x86_64']): Copr: 'packit/containers-ramalama-274' already exists. Copr HTTP response is 400 BAD REQUEST.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@josiahbryan josiahbryan mentioned this pull request Oct 9, 2024
@josiahbryan
Copy link
Contributor Author

@ericcurtin suggestions on the failure above? Obviously from the commit, I didn't change any code, just two markdown files - anything I need to change to get this to pass the tests? (See error above about 'packit/containers-ramalama-274') - this is in relation to #265

@ericcurtin
Copy link
Collaborator

The failure is because you didn't sign your commit, please amend your commits with:

git commit -s --amend

I really wish we had a bot that delivered this feedback on failed DCO build, this happens all the time

@josiahbryan
Copy link
Contributor Author

Just did the git commit -s --amend and found I had to force-update the branch - hope that did everything correctly! Thanks @ericcurtin - let's see what happens when DCO tries again here shortly lol

@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2024

Could you rebase this, then the CI/CD system will be fixed.

git pull origin main
git commit -a --amend -s
git push --force

…lling error

Signed-off-by: Josiah Bryan <josiahbryan@gmail.com>
@josiahbryan
Copy link
Contributor Author

@ericcurtin I think I got it all resolved - should be good to go now.

@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2024

LGTM

@rhatdan rhatdan merged commit 7e540bd into containers:main Oct 9, 2024
10 of 11 checks passed
@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2024

Thanks @josiahbryan

@josiahbryan josiahbryan deleted the serve-api-docs-pr branch October 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants