Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add OWNERS file #1420

Merged
merged 1 commit into from
Aug 18, 2021
Merged

[CI:DOCS] Add OWNERS file #1420

merged 1 commit into from
Aug 18, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Aug 17, 2021

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do anything right now? Or is it a prerequisite for turning on a bot in the future?

@TomSweeneyRedHat
Copy link
Member

@mtrmac @jberkus is putting together some thoughts on Governance for the Containers organization. The first step is to have an owners.md file in each of the containers/* projects. I don't know if a bot will be involved or not for sure, I don't believe so. It's primarily being used so the future Governance document, likely in c/common, can say "Look at the owners.md file for a project ...". Not so much for this project, but for the smaller ones it would be handy to have such a file in case there's ever a CVE reported against it.

@TomSweeneyRedHat
Copy link
Member

I'm confused why a PR with only a new file would ever need a rebase?
LGTM

@rhatdan
Copy link
Member Author

rhatdan commented Aug 18, 2021

This is for Governance, We will be opening similar PRs for other REPOS.

@mtrmac
Copy link
Contributor

mtrmac commented Aug 18, 2021

Thanks for the explanation.


I'm confused why a PR with only a new file would ever need a rebase?

“Does it need a rebase” is a different question, and GitHub indicates that one by “has conflicts that needs to be resolved”.

I think it’s just doing a graph shape check; that answers “did the submitter (get a chance to) test this on top of the latest version” — a zero-conflict PR could still be broken by other changes to the codebase; so some projects have a policy of asking the submitters to test against a recent version. Of course that doesn’t scale past some amount of changes.

Anyway, humans with judgement about such drift risk can use a big hammer to merge anyway, so let’s do that.

@mtrmac mtrmac merged commit 291bbdf into containers:main Aug 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants