-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Add OWNERS file #1420
Conversation
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this do anything right now? Or is it a prerequisite for turning on a bot in the future?
@mtrmac @jberkus is putting together some thoughts on Governance for the Containers organization. The first step is to have an owners.md file in each of the containers/* projects. I don't know if a bot will be involved or not for sure, I don't believe so. It's primarily being used so the future Governance document, likely in c/common, can say "Look at the owners.md file for a project ...". Not so much for this project, but for the smaller ones it would be handy to have such a file in case there's ever a CVE reported against it. |
I'm confused why a PR with only a new file would ever need a rebase? |
This is for Governance, We will be opening similar PRs for other REPOS. |
Thanks for the explanation.
“Does it need a rebase” is a different question, and GitHub indicates that one by “has conflicts that needs to be resolved”. I think it’s just doing a graph shape check; that answers “did the submitter (get a chance to) test this on top of the latest version” — a zero-conflict PR could still be broken by other changes to the codebase; so some projects have a policy of asking the submitters to test against a recent version. Of course that doesn’t scale past some amount of changes. Anyway, humans with judgement about such drift risk can use a big hammer to merge anyway, so let’s do that. |
Signed-off-by: Daniel J Walsh dwalsh@redhat.com