Remove the extra (defaults to true) help msg #1431
Conversation
|
Couple nits for consideration |
There was a problem hiding this comment.
I’m afraid this is just incorrect; optionalBoolFlag’s default is not (present=true, value=true), it is (present=false, value=N/A).
In particular --tls-verify=true overrides an insecure field in registries.conf, but missing --tls-verify=true uses the insecure field’s value.
… actually, as long as it doesn’t show up in any user-visible text, nor in any user-visible behavior, that might be fine. But that needs a somewhat comprehensive argument (and given the brittleness, a written record in the commit message or PR) of why that is the case. |
By default skopeo checks to see if the user actually uses one of the --*tls-verify flags. Their initial value is ignored. Setting the initial value to false causes Cobra to not display the default value on the screen when the user runs a `skopeo --help` command. If the user does not specify a --*tls-verify option, it falls back to using the value specified in the registries.conf file. Fixes: containers#1383 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@mtrmac commit message good now? |
|
@mtrmac @vrothberg PTAL |
By default skopeo checks to see if the user actually uses one of the
--*tls-verify flags. Their initial value is ignored. Setting the
initial value to false causes Cobra to not display the default value on
the screen when the user runs a
skopeo --helpcommand.If the user does not specify a --*tls-verify option, it falls back to
using the value specified in the registries.conf file.
Fixes: #1383
Signed-off-by: Daniel J Walsh dwalsh@redhat.com