-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation doc with latest steps #1464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK other than the macOS keychain part.
Thanks!
install.md
Outdated
@@ -62,19 +39,23 @@ sudo apk add skopeo | |||
brew install skopeo | |||
``` | |||
|
|||
You may need to add registry certificate to your macOS truststore. | |||
``` | |||
sudo security add-trusted-cert -d -r trustRoot -k /Library/Keychains/System.keychain <registry_cert.crt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part doesn’t make sense to me.
- AFAICS this has nothing to do with installing Skopeo; just the
brew install
does that. - WRT configuring a certificate trusted to connect to a registry, platform-agnostic paths like
--cert-dir
are still expected to work - All of Support MacOS keychain for ca's #563 ended up surprising to me. The original report was that that CAs from the macOS keychain were ignored, and the recommended fix is to … add the CA to the macOS keychain? Stated this way, it just does not follow at all, so there must be some subtlety to Support MacOS keychain for ca's #563 that wasn’t written down.
Overall I think this part of the PR should just be dropped, and #563 either discussed further, or just closed as “2 years later, this was reported to work fine”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, will do. thanks @mtrmac , and apologies if this bothered you on your PTO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(No worries — I chose to take a little time to see what’s new, and I know I had the option not to. But I appreciate the thought all the same.)
42215b4
to
7be45e9
Compare
removed macos part. PTAL |
7be45e9
to
e7e9e04
Compare
Also, added a note for Windows package absence. PTAL as well. |
@vrothberg @rhatdan @TomSweeneyRedHat tests are green. PTAL |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that Ubuntu should get a dedicated section along with the info that skopeo is the main repositories starting with 20.10
install.md
Outdated
CAUTION: On Ubuntu 20.10 and newer, we highly recommend you use Buildah, Podman and Skopeo ONLY from EITHER the Kubic repo | ||
OR the official Ubuntu repos. Mixing and matching may lead to unpredictable situations including installation conflicts. | ||
The [Kubic project](https://build.opensuse.org/package/show/devel:kubic:libcontainers:stable/skopeo) | ||
provides packages for active Ubuntu 20.04 (it should also work with direct derivatives like Pop!\_OS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provides packages for active Ubuntu 20.04 (it should also work with direct derivatives like Pop!\_OS). | |
provides packages for Ubuntu 20.04 (it should also work with direct derivatives like Pop!\_OS). |
Not sure what "active" means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it just 20.24 or "20.24 and later"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what "active" means.
@vrothberg ha, active
was a poor choice, I wanted to mean something that's not EOL, and yes, we could just get rid of that word.
is it just 20.24 or "20.24 and later"?
@TomSweeneyRedHat in the case of podman, we're not mentioning kubic repos if the package exists in the default distro repos. I'm hoping to do the same here.
Ubuntu already has a dedicated section. Listed below debian and raspberry pi os. Can you check again and let me know if you meant something else? |
- Remove Kubic repo suggestions where skopeo exists by default - Include documentation about lack of Windows package (RE: containers#715) Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
e7e9e04
to
e0c53df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Apologies, it looked like it was in the Debian section. |
Update installation doc with latest steps
(RE: Documentation does not mention Windows binary of Skopeo. #715)
Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org
@vrothberg @mtrmac @rhatdan @TomSweeneyRedHat @lbscorpio PTAL