Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]: make sure that CGO_ENABLED is enable #2229

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

miltkall-asml
Copy link
Contributor

As we found out with kind Sir Miloslav Trmač, CGO_ENABLED has to enabled in order for the installed system libraries to get used and compile successfully.

Best Regards!

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

install.md Outdated Show resolved Hide resolved
install.md Outdated Show resolved Hide resolved
Signed-off-by: Miltiadis Kallianis <miltiadis.kallianis@klarrio.com>
Signed-off-by: Miltiadis Kallianis <miltiadis.kallianis@asml.com>
Move docs under "Building without a container".
Check instead of setting env variable.
Provide alternative approach.

Signed-off-by: Miltiadis Kallianis <miltiadis.kallianis@asml.com>
@miltkall-asml
Copy link
Contributor Author

Sorry for the delay. Thanks for the review!

Hope this satisfies you 😃

Signed-off-by: Miltiadis Kallianis <miltiadis.kallianis@asml.com>
@TomSweeneyRedHat
Copy link
Member

LGTM
The CI issues are known, hopefully we'll be able to rerun the failed tests soon and get this in.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtrmac mtrmac merged commit d7c99d5 into containers:main Feb 20, 2024
24 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants