Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] RPM: bats requirement only on Fedora #2320

Merged
merged 1 commit into from
May 7, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 7, 2024

The bats package is not available on RHEL. It's in Fedora and EPEL.

Having bats as a requirement for the skopeo-tests subpackage will cause installibility test failures for RHEL 10 / C10S gating tests.

This commit makes bats a requirement only on Fedora. RHEL and CentOS Stream gating will need to fetch bats through separately enabling EPEL or other means.

Podman PR with similar change: containers/podman#22632

The bats package is not available on RHEL. It's in Fedora and EPEL.

Having bats as a requirement for the `skopeo-tests` subpackage will
cause installibility test failures for RHEL 10 / C10S gating tests.

This commit makes `bats` a requirement only on Fedora. RHEL and CentOS
Stream gating will need to fetch bats through separately enabling EPEL
or other means.

Podman PR with similar change: containers/podman#22632

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5 lsm5 marked this pull request as ready for review May 7, 2024 17:26
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let’s follow Podman’s lead here, then.

Cc: also @jnovy for possible packaging / automation impact.

@mtrmac mtrmac merged commit 2b6c7ad into containers:main May 7, 2024
22 of 26 checks passed
@lsm5 lsm5 deleted the rhel-no-bats branch May 7, 2024 17:52
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants