Execute cross-build task using PW pool #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ephemeral COPR build failed. @containers/packit-build please check. |
mtrmac
reviewed
May 30, 2024
cevich
force-pushed
the
cross_on_pool
branch
2 times, most recently
from
61babfd to
b1ea0b2
Compare
|
Leaving this on Draft: I need to update the Mac deployment setup script so it installs |
Previously this task ran using the Cirrus-CI compute service, consuming compute credits. However, since podman is already using a persistent worker pool for CI, it can also be leveraged for use here. Since Mac resources are relatively expensive, it also makes financial sense to re-use infrastructure where possible. Notes: - This change also restricts the cross-build task to only running on the default branch. This is necessary because the PW Pool environment is always rolling forward and may not match what was in place at the time a release-branch was created. - This changes the test from an install + run, to just a build + run. This is required because the task is running as a regular user w/o permissions to install anything system-wide, on a host shared with other CI tasks. Signed-off-by: Chris Evich <cevich@redhat.com>
|
force-push: Rebased. This should be ready to go now. |
mtrmac
approved these changes
Jun 3, 2024
| - go version | ||
| - go env | ||
| - make tools | ||
| - make validate-local test-unit-local bin/skopeo |
There was a problem hiding this comment.
I think (as the failures here show) make bin/skopeo test-unit-local validate-local might be more helpful, but that’s pre-existing and unrelated.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this task ran using the Cirrus-CI compute service, consuming compute credits. However, since podman is already using a persistent worker pool for CI, it can also be leveraged for use here. Since Mac resources are relatively expensive, it also makes financial sense to re-use infrastructure where possible.
Notes: