Bump github.com/hashicorp/go-retryablehttp from 0.7.6 to 0.7.7

[dependabot]

Bumps github.com/hashicorp/go-retryablehttp from 0.7.6 to 0.7.7.

Changelog

Sourced from github.com/hashicorp/go-retryablehttp's changelog.

0.7.7 (May 30, 2024)

BUG FIXES:

• client: avoid potentially leaking URL-embedded basic authentication credentials in logs (#158)

Commits

• 1542b31 v0.7.7
• defb9f4 v0.7.7
• a99f07b Merge pull request #158 from dany74q/danny/redacted-url-in-logs
• 8a28c57 Merge branch 'main' into danny/redacted-url-in-logs
• 86e852d Merge pull request #227 from hashicorp/dependabot/github_actions/actions/chec...
• 47fe99e Bump actions/checkout from 4.1.5 to 4.1.6
• 490fc06 Merge pull request #226 from testwill/ioutil
• f3e9417 chore: remove refs to deprecated io/ioutil
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  You can disable automated security fix PRs for this repo from the Security Alerts page.

[mtrmac]

@TomSweeneyRedHat for the record, the basic auth disclosure is irrelevant to Skopeo.

[TomSweeneyRedHat]

@mtrmac Are you sure, I thought I spotted a NewClient call for retryablehttp down in Rekor code. But, I'd be happy to close the Skopeo CVEs out for this.

[TomSweeneyRedHat]

Addresses: https://issues.redhat.com/browse/RHEL-44886

[TomSweeneyRedHat]

Also addresses: https://issues.redhat.com/browse/RHEL-44890

[TomSweeneyRedHat]

Also addresses: https://issues.redhat.com/browse/OCPBUGS-36126

[mtrmac]

@mtrmac Are you sure, I thought I spotted a NewClient call for retryablehttp down in Rekor code.

Yes, there’s

skopeo/vendor/github.com/sigstore/rekor/pkg/client/rekor_client.go

Line 38 in ce8e984

retryableClient := retryablehttp.NewClient()

.

But AFAICS the parameters of that function don’t allow providing credentials (and the rekorServerURL value is deconstructed into components in a way that discards basic auth credentials even if they were present).

(The code is using a go-openapi/runtime abstraction which does have a path to set basic auth credentials; but it’s not used for the Rekor client calls. So all of this analysis applies only to go-retryablehttp calls from this GetRekorClient function, and to the logger adapter in c/image.)