Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.22 #2417

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Update to Go 1.22 #2417

merged 3 commits into from
Sep 4, 2024

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Sep 3, 2024

Cc: @Luap99

@lsm5 PTAL — marking as draft to let you review, to make sure this is not a problem for downstream.

@Luap99
Copy link
Member

Luap99 commented Sep 3, 2024

You will need something like containers/podman@54b8c4f to fix the packit config to no longer build in envs with go 1.21

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Based on containers/podman@54b8c4f
by Paul Holzinger <pholzing@redhat.com> .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not a problem for downstream. We'll simply end up not updating f39 which will be going EOL in maybe a couple of months.

@mtrmac mtrmac marked this pull request as ready for review September 4, 2024 14:53
@mtrmac
Copy link
Contributor Author

mtrmac commented Sep 4, 2024

Thanks! Ready for merging, then.

@rhatdan rhatdan merged commit 4c9ec00 into containers:main Sep 4, 2024
23 checks passed
@mtrmac mtrmac deleted the go1.22 branch September 4, 2024 16:46
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants