Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Zsh completion #836

Closed
travier opened this issue Jul 12, 2021 · 3 comments
Closed

RFE: Zsh completion #836

travier opened this issue Jul 12, 2021 · 3 comments
Labels
1. Feature request A request for a new feature
Milestone
Release 0.1.0

Comments

@travier
Copy link
Member

travier commented Jul 12, 2021 •
edited
Loading

Provide Bash & (already available) Zsh completion for command line options.

This is already supported by the argument parsing library currently used in toolbox (https://github.com/spf13/cobra/blob/master/shell_completions.md).
@travier travier added the 1. Feature request A request for a new feature label Jul 12, 2021
@travier travier changed the title RFE: Bash & Zsh completion RFE: Zsh completion Jul 12, 2021
@olivergs olivergs mentioned this issue Jul 16, 2021
Merged
@olivergs
Copy link
Collaborator

@travier I've created this PR:

#840

It is still a WIP and needs some work, but it is able to generate the Zsh completions by using

toolbox completion zsh

That will output the completions to stdout.

If you could check them works as expected from a Zsh user POV would be great.

@travier
Copy link
Member Author

travier commented Jul 16, 2021

Thanks! Will take a look.

@gotmax23 gotmax23 mentioned this issue Oct 31, 2021
Closed
@HarryMichal HarryMichal added this to the Release 0.1.0 milestone Jan 13, 2022
@HarryMichal
Copy link
Member

This has been fixed by #840.

debarshiray added a commit to containers/containertoolbx.org that referenced this issue Sep 27, 2023
@debarshiray
Add fish to the list of optional build dependencies
50a457b 
See:
containers/toolbox@bafbbe81c9220cb3
containers/toolbox#836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. Feature request A request for a new feature
Projects
None yet
Milestone
Release 0.1.0
Development

No branches or pull requests
3 participants
@olivergs @HarryMichal @travier