Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 151: updates welcome message to remove formatted link #1090

Conversation

tonytheleg
Copy link

  • Fixes Issue 151 which has a PR pending but looks to have failed tests and is from 2020. Not sure if it wasn't merged for that reason.
  • Tested locally with Fedora 35, 36, and 37 releases in toolbox

Signed-off-by: Tony Natale <anatale@protonmail.com>
@tonytheleg tonytheleg force-pushed the issue-151-update-welcome-message branch from 4cbab3b to c64456c Compare August 25, 2022 23:56
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ system-test-fedora-rawhide SUCCESS in 27m 37s
✔️ system-test-fedora-36 SUCCESS in 12m 04s
✔️ system-test-fedora-35 SUCCESS in 12m 16s

@matthiasclasen
Copy link
Collaborator

I'm not convinced that is an improvement, tbh.

Reading the original issue, I would say the real problem is that clicking did not open the link

@tonytheleg
Copy link
Author

I'm not convinced that is an improvement, tbh.

Reading the original issue, I would say the real problem is that clicking did not open the link

Yeah I can't disagree there, the link worked fine in Gnome Terminal and personally I think looks more visually appealing. I was already looking at another issue and saw this one and figured I'd take it since it was an easy adjustment

@debarshiray
Copy link
Member

I'm not convinced that is an improvement, tbh.

Reading the original issue, I would say the real problem is that clicking did not open the link

Yes, I agree. As I mentioned in the original issue, the exact handling of hyperlinks is something that's worth discussing with the terminal emulators, before removing it from Toolbx.

@debarshiray
Copy link
Member

Closing.

@tonytheleg Thanks for your interest in Toolbx, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in welcome messages are a little confusing
3 participants