Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new packages #1124

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Add new packages #1124

merged 2 commits into from
Sep 14, 2022

Conversation

nievesmontero
Copy link
Collaborator

The following packages have been added to the
image to make OpenGL and Vulkan work:
mesa-dri-drivers
mesa-vulkan-drivers
vulkan-loader

#1110

@nievesmontero
Copy link
Collaborator Author

We still have to test whether the new packages work when launching Toolbox.

@nievesmontero
Copy link
Collaborator Author

The packages have been tested and they work on the image.

Copy link
Collaborator

@matthiasclasen matthiasclasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

Copy link
Member

@debarshiray debarshiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, Nieves!

This looks good to me. Could you please do the same thing for the Fedora 36 and 35 images? Those Fedoras are still supported, and since this isn't a big change, it will be good to make life easier for our users.

nievesmontero added a commit to nievesmontero/toolbox that referenced this pull request Sep 13, 2022
The following packages have also been added to images f36 and f35:
mesa-dri-drivers
mesa-vulkan-drivers
vulkan-loader

containers#1124
nievesmontero added a commit to nievesmontero/toolbox that referenced this pull request Sep 13, 2022
The following packages have also been added to images f36 and f35:
mesa-dri-drivers
mesa-vulkan-drivers
vulkan-loader

containers#1124
Signed-off-by: Nieves Montero <nmontero@redhat.com>
@nievesmontero
Copy link
Collaborator Author

The new packages have been added to both, f36 and f35, they're pending to be tested.

@matthiasclasen
Copy link
Collaborator

You will have to redo the first commit with a sign-off to make check go green

The following packages have been added to the
image to make OpenGL and Vulkan work:
mesa-dri-drivers
mesa-vulkan-drivers
vulkan-loader

containers#1110
Signed-off-by: Nieves Montero <nmontero@redhat.com>
The following packages have also been added to images f36 and f35:
mesa-dri-drivers
mesa-vulkan-drivers
vulkan-loader

containers#1124
Signed-off-by: Nieves Montero <nmontero@redhat.com>
@travier
Copy link
Member

travier commented Dec 5, 2022

Hey folks. When you add packages to the Fedora toolbox image, could you also open an issue in the https://github.com/toolbx-images/images repo? That would it much easier for us to keep things in sync. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants