test/system: Ensure that $HOME is used as a fallback working directory #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Nov 9, 2022
We need a directory that's going to be present on the host operating system across various configurations of all supported distributions, such as the hosts running the CI, but not inside the Toolbx containers. It looks like /etc/kernel is present on both Debian and Fedora, but absent from the fedora-toolbox images. On a Debian 10 server, it's owned by several packages: $ dpkg-query --search /etc/kernel dkms, systemd, grub2-common, initramfs-tools, apt: /etc/kernel ... while on Fedora 36 Workstation: $ rpm --file --query /etc/kernel systemd-udev-250.8-1.fc36.x86_64 containers#1153
debarshiray
force-pushed
the
wip/rishi/test-system-run-ensure-home-as-fallback
branch
from
47ebb7a to
45b409f
Compare
|
Build succeeded. ✔️ system-test-fedora-rawhide SUCCESS in 22m 21s |
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Nov 10, 2022
This needs a directory that's going to be present on the host operating system across various configurations of all supported distributions, such as the hosts running the CI, but not inside the Toolbx containers. It looks like /etc/kernel is present on both Debian and Fedora, but absent from the fedora-toolbox images. On a Debian 10 server, it's owned by several packages: $ dpkg-query --search /etc/kernel dkms, systemd, grub2-common, initramfs-tools, apt: /etc/kernel ... while on Fedora 36 Workstation: $ rpm --file --query /etc/kernel systemd-udev-250.8-1.fc36.x86_64 Currently, there's no way to get assert_line to use the stderr_lines array [1]. This is worked around by assigning stderr_lines to the lines array. [1] bats-core/bats-assert#42 containers#1153
debarshiray
force-pushed
the
wip/rishi/test-system-run-ensure-home-as-fallback
branch
from
45b409f to
cc74311
Compare
This needs a directory that's going to be present on the host operating system across various configurations of all supported distributions, such as the hosts running the CI, but not inside the Toolbx containers. It looks like /etc/kernel is present on both Debian and Fedora, but absent from the fedora-toolbox images. On a Debian 10 server, it's owned by several packages: $ dpkg-query --search /etc/kernel dkms, systemd, grub2-common, initramfs-tools, apt: /etc/kernel ... while on Fedora 36 Workstation: $ rpm --file --query /etc/kernel systemd-udev-250.8-1.fc36.x86_64 Currently, there's no way to get assert_line to use the stderr_lines array [1]. This is worked around by assigning stderr_lines to the 'lines' array. [1] bats-core/bats-assert#42 containers#1153
debarshiray
force-pushed
the
wip/rishi/test-system-run-ensure-home-as-fallback
branch
from
cc74311 to
741603c
Compare
|
Build succeeded. ✔️ system-test-fedora-rawhide SUCCESS in 33m 13s |
debarshiray
deleted the
wip/rishi/test-system-run-ensure-home-as-fallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a directory that's going to be present on the host operating system across various configurations of all supported distributions, such as the hosts running the CI, but not inside the Toolbx containers.
It looks like
/etc/kernelis present on both Debian and Fedora, but absent from the fedora-toolbox images. On a Debian 10 server, it's owned by several packages:... while on Fedora 36 Workstation:
Currently, there's no way to get
assert_lineto use thestderr_linesarray [1]. This is worked around by assigningstderr_linesto thelinesarray.[1] bats-core/bats-assert#42