libcgroup and libcontainers examples and README #1483
Conversation
krisnova
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
- Coverage 68.78% 68.77% -0.02%
==========================================
Files 120 120
Lines 13082 13086 +4
==========================================
+ Hits 8999 9000 +1
- Misses 4083 4086 +3 |
|
@krisnova Thanks for your contribution! I love your idea, but it looks like that CI got failed. May I ask you to check and fix it? If you need help, please ask me. You may leave the bpf example off for the moment. In that case, it would be helpful if you could create an issue. |
|
Yes sounds good I will send more follow up commits. I will also add more README files where I work and offer other small improvements as I work if this is acceptable to Youki. |
Signed-off-by: Kris Nóva <kris@nivenly.com>
Signed-off-by: Kris Nóva <kris@nivenly.com>
Signed-off-by: Kris Nóva <kris@nivenly.com>
krisnova
force-pushed
the
examples-readme
branch
from
05463ea
to
f735a88
Compare
| }; | ||
| use anyhow::{bail, Context, Ok, Result}; | ||
| use nix::mount::MsFlags; | ||
| use nix::sched::CloneFlags; | ||
| use nix::sys::stat::Mode; | ||
| use nix::unistd::setsid; | ||
|
|
||
| use log::warn; |
There was a problem hiding this comment.
Hey, it seems this is making clippy fail. Can you remove this and check if it fixes it?
|
Hey @krisnova , The examples and docs are something that we definitely need, but can we not make code changes in this PR then, and keep it just for docs / comment docs? |
|
Yes makes sense I will get it cleaned up. |
As I have been working on Aurae project I would have found value in some README and examples. I created the things that would have been helpful for me, in the hopes they will make it easy for others to adopt Youki.
Signed-off-by: Kris Nóva kris@nivenly.com