Implement thiserror for libcontainer - Part 1
#1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <yihuaf@unkies.org>
Signed-off-by: yihuaf <yihuaf@unkies.org>
Signed-off-by: yihuaf <yihuaf@unkies.org>
… etc. Signed-off-by: yihuaf <yihuaf@unkies.org>
Signed-off-by: yihuaf <yihuaf@unkies.org>
Signed-off-by: yihuaf <yihuaf@unkies.org>
Signed-off-by: yihuaf <yihuaf@unkies.org>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
==========================================
- Coverage 68.16% 67.70% -0.46%
==========================================
Files 122 124 +2
Lines 14011 14205 +194
==========================================
+ Hits 9550 9618 +68
- Misses 4461 4587 +126 |
9 tasks
utam0k
reviewed
May 4, 2023
| @@ -8,3 +8,109 @@ pub mod syscall; | |||
| pub mod test; | |||
|
|
|||
| pub use syscall::Syscall; | |||
| #[derive(Debug, thiserror::Error)] | |||
| pub enum SyscallError { | |||
utam0k
approved these changes
May 4, 2023
|
@squili May I ask you to review this PR? |
squili
approved these changes
May 4, 2023
|
Thanks @squili |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt to add
thiserrortolibcontainerand all comments are welcome. Note, I decide to break this effort into multiple parts because a single PR would be too large to reasonably review. The aim is to start at the bottom turning the errors intothiserrorwhile keeping the top levelanyhow::Erroruntil we finish this effort. By keeping the top level asanyhow::Errorfor the moment, we can easily turnthiserrorinto ananyhow::Error, but not vice versa.A few notes. I tried my best to create appropriate error, but they are not perfect in any means. I would like in this PR to focus on the broader effort to make the transition, instead of focusing on the specifics of a single error. We can always make additional PR to fix.
I am not sure if I am using the
libcgroupserror correctly. For now, I just turned them into string messages. We may need to spend more effort since it currently only returns astd::error::Error + 'statictrait, rather than a concrete type where to can expose structurally.