Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add basic github actions for build/release #101

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Apr 28, 2023

This PR adds a github workflow that should be roughly equal to the drone build. It also adds simple image building to the Build workflow so that it now both runs shellcheck and tries to build the docker image.
What it doesn't do right now is pushing said docker image to any repository (for PRs). Perhaps this could be done the same way as before (tagging as PR-xxx), but only pushing those to GHCR (to keep them out of the "official" space)?

Speaking of which, this only pushes to GHCR currently since the docker repository (mazzolino/shepherd) hasn't been transferred to containrrr/shepherd.

@djmaze
Copy link
Collaborator

djmaze commented Apr 29, 2023

Unfortunately I don't know much about github actions (and I try to stay away from them), but for me this looks okay so far.

@djmaze
Copy link
Collaborator

djmaze commented Apr 29, 2023

Speaking of which, this only pushes to GHCR currently since the docker repository (mazzolino/shepherd) hasn't been transferred to containrrr/shepherd.

AFAIK a real transfer with an automated "forwarding" is not possible at dockerhub. I would prefer if we just begin pushing the new versions to the containrrr namespace (and update the documentation) and leave the old image in my namespace for backwards compatibility reasons.

@piksel
Copy link
Member Author

piksel commented May 18, 2023

Yeah, I think you are right. We still have the problem that people report bugs that seems suspiciously like ones we have fixed a long time ago that turns out to be because they are using the old namespace (v2tec/watchtower). I will add the dockerhub pushing as well.

@moschlar
Copy link
Collaborator

moschlar commented Aug 18, 2023

@piksel If you mark this PR ready (maybe after adding the dockerhub pushing), I'd be happy to merge and update the docs to the new image name (and maybe an issue template nagging people to check they are using the new image path 😉 )

@moschlar moschlar marked this pull request as ready for review October 5, 2023 08:03
Copy link
Collaborator

@moschlar moschlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I don't have much experience with GitHub Actions so far :-D

@moschlar moschlar merged commit b6d2013 into master Oct 5, 2023
4 checks passed
@moschlar moschlar added this to the 1.8.0 milestone Oct 5, 2023
@piksel
Copy link
Member Author

piksel commented Oct 5, 2023

Sorry for the lack of response here. I think the only things needed for dockerhub is to uncomment the docker hub login and the image name below the ghcr.io one. I think the credentials should be available to push images to the containrrr namespace. Let me know if you have problems with it!

moschlar added a commit that referenced this pull request Oct 30, 2023
[Full Changelog](0.7.0...1.8.0)

**Breaking changes:**

- The docker image registry location has been changed to the containrrr organisation:
  `containrrr/shepherd`

**Implemented enhancements:**

- armhf support [\#108](#108)
- Switch to official docker image v24 [\#107](#107) ([djmaze](https://github.com/djmaze))
- Restrict runtime of "docker service update" using "timeout" [\#98](#98) ([fooflington](https://github.com/fooflington))
- Add example for usage with swarm-cronjob [\#89](#89) ([djmaze](https://github.com/djmaze))

**Fixed bugs:**

- Can't update some services: no such manifest [\#105](#105)
- Service gets stuck when calling "docker service update" and won't progress [\#97](#97)
- fix: docker service update with `--detach=false` hangs on services wi… [\#104](#104) ([AliRezaBeitari](https://github.com/AliRezaBeitari))
- Fix defunc VERBOSE handling [\#91](#91) ([sebthom](https://github.com/sebthom))

**Closed issues:**

- How does it determine if there is an update or not? [\#111](#111)
- Looking for a new maintainer [\#96](#96)
- New OCI manifest issue [\#92](#92)
- Run service update at a fixed time [\#88](#88)
- docker swarm 20.10.12 | "docker service update" requires exactly 1 argument. [\#83](#83)
- Error updating service, does not exist or it is not available when using a duplicate registry [\#78](#78)

**Merged pull requests:**

- Add apprise type and additional error notification [\#118](#118) ([andyloree](https://github.com/andyloree))
- Rename image in docs [\#114](#114) ([moschlar](https://github.com/moschlar))
- Fix release workflow [\#113](#113) ([moschlar](https://github.com/moschlar))
- Update README.md [\#103](#103) ([andrew-dixon](https://github.com/andrew-dixon))
- ci: add basic github actions for build/release [\#101](#101) ([piksel](https://github.com/piksel))
- correct misleading description of WITH\_NO\_RESOLVE\_IMAGE [\#100](#100) ([alex-vg](https://github.com/alex-vg))
- Move example configs to their own folder [\#99](#99) ([djmaze](https://github.com/djmaze))
- Add documentation about `REGISTRIES_FILE` [\#94](#94) ([tito](https://github.com/tito))
- Minor refactoring [\#90](#90) ([sebthom](https://github.com/sebthom))

Closes: #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants