Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: other flags may not be combined with --rollback #121

Merged

Conversation

AliRezaBeitari
Copy link
Contributor

As stated here, you should not pass other flags with the --rollback flag. Otherwise, you will get this error message:

other flags may not be combined with --rollback

And this error causes the shepherd container to exist with a non-zero exit code:

ID             NAME             IMAGE                       NODE   DESIRED STATE   CURRENT STATE            ERROR                       PORTS
mt76rdcbfaaz   shepherd.1       mazzolino/shepherd:latest   main   Running         Running 13 minutes ago
j1hi6zqylbdn    \_ shepherd.1   mazzolino/shepherd:latest   main   Shutdown        Failed 13 minutes ago    "task: non-zero exit (1)"
xyj7e0r52vog    \_ shepherd.1   mazzolino/shepherd:latest   main   Shutdown        Failed 3 hours ago       "task: non-zero exit (1)"
vd0nvzo9kd2y    \_ shepherd.1   mazzolino/shepherd:latest   main   Shutdown        Failed 4 hours ago       "task: non-zero exit (1)"
53azr021ok4i    \_ shepherd.1   mazzolino/shepherd:latest   main   Shutdown        Failed 4 hours ago       "task: non-zero exit (1)"

For this reason, I removed the --no-resolve-image and --with-registry-auth flags from the rollback command.

Copy link
Collaborator

@moschlar moschlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have additionally checked about the $detach_option by looking through docker/cli#144 and it seems to be good now!

@moschlar moschlar merged commit e74ea80 into containrrr:master Nov 30, 2023
2 checks passed
@AliRezaBeitari AliRezaBeitari deleted the fix/rollback-with-other-flags branch November 30, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants