Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Dockerfile.dev-self-contained to allow better build cache #1755

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

jebabin
Copy link
Contributor

@jebabin jebabin commented Sep 8, 2023

Currently, when using the dockerfile, module are downloaded each time.
This change pre download the module in a early stage so that docker layer caching avoid module redownload at next build

Allow to use docker layer caching to avoid module redownload at each build
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (36391b0) 67.60% compared to head (b513b7c) 67.60%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1755   +/-   ##
=======================================
  Coverage   67.60%   67.60%           
=======================================
  Files          26       26           
  Lines        2380     2380           
=======================================
  Hits         1609     1609           
  Misses        672      672           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piksel piksel changed the title Update Dockerfile.dev-self-contained to allow better build cache chore: update Dockerfile.dev-self-contained to allow better build cache Sep 18, 2023
@piksel piksel merged commit 9b28fbc into containrrr:main Sep 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants