Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Dockerfile to use Go modules and go install #2002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

So4resAlex
Copy link

What this PR contributes

This PR updates the documentation to include an updated Dockerfile that simplifies the build process for amazon-ecr-credential-helper. The following changes have been made:

Enabled Go modules (GO111MODULE=on)
Simplified installation using go install with the latest version of the repository
Set a default command to run docker-credential-ecr-login
Added comments for better readability and maintainability

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant