Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config sanity check #925

Merged
merged 4 commits into from
Apr 24, 2021
Merged

config sanity check #925

merged 4 commits into from
Apr 24, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Apr 24, 2021

This will check the container configuration for obvious errors before trying to recreate it, preventing at least some know fault conditions.

@piksel piksel requested a review from simskij as a code owner April 24, 2021 10:34
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #925 (4097c85) into main (b4cf17d) will increase coverage by 6.48%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   40.14%   46.62%   +6.48%     
==========================================
  Files          25       25              
  Lines        1415     1437      +22     
==========================================
+ Hits          568      670     +102     
+ Misses        785      700      -85     
- Partials       62       67       +5     
Impacted Files Coverage Δ
internal/actions/update.go 50.47% <30.00%> (-0.55%) ⬇️
pkg/container/container.go 47.31% <100.00%> (+47.31%) ⬆️
pkg/notifications/shoutrrr.go 73.43% <100.00%> (+0.42%) ⬆️
pkg/notifications/email.go 90.90% <0.00%> (+4.54%) ⬆️
pkg/container/client.go 14.59% <0.00%> (+14.59%) ⬆️
pkg/container/metadata.go 63.63% <0.00%> (+63.63%) ⬆️
pkg/container/util.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38e52b...4097c85. Read the comment docs.

@piksel piksel force-pushed the feature/config-sanity-check branch from ff1ee6c to 223a14b Compare April 24, 2021 11:34
@piksel piksel force-pushed the feature/config-sanity-check branch from e0658f6 to e801506 Compare April 24, 2021 13:48
@piksel piksel merged commit 1246771 into main Apr 24, 2021
@piksel piksel deleted the feature/config-sanity-check branch May 5, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant