Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICU requirements check for Contao 4.5 #214

Closed
ausi opened this issue Feb 5, 2018 · 5 comments
Closed

Add ICU requirements check for Contao 4.5 #214

ausi opened this issue Feb 5, 2018 · 5 comments

Comments

@ausi
Copy link
Member

ausi commented Feb 5, 2018

See contao/check#136
@Toflar Toflar added the feature label Jun 7, 2018
@aschempp
Copy link
Member

aschempp commented Nov 7, 2018

Is this still necessary since we changed the ICU requirements?

@ausi
Copy link
Member Author

ausi commented Nov 7, 2018

IMO yes. The minimum ICU version is 4.2.1 now, see contao/check@3b06187

@aschempp
Copy link
Member

aschempp commented Nov 9, 2018

If I understand correctly, this is only a requirement for Contao 4.5 and later? So the manager should be able to install Contao 4.4, which means this can't be a "fail" check.

@ausi
Copy link
Member Author

ausi commented Nov 9, 2018

Correct.

@aschempp aschempp added wontfix and removed feature labels Aug 8, 2019
@aschempp
Copy link
Member

aschempp commented Aug 8, 2019

I think this is obsolete by now.

@aschempp aschempp closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ausi @Toflar @aschempp