Skip to content
This repository has been archived by the owner on Jan 2, 2020. It is now read-only.

Add ICU requirement for Contao 4.5 #136

Closed
ausi opened this issue Feb 5, 2018 · 5 comments
Closed

Add ICU requirement for Contao 4.5 #136

ausi opened this issue Feb 5, 2018 · 5 comments

Comments

@ausi
Copy link
Member

ausi commented Feb 5, 2018

Contao 4.5 needs the intl extension with the ICU version 4.6 or higher.
See contao/core-bundle#1352 (comment)
@fritzmg
Copy link
Collaborator

fritzmg commented Feb 5, 2018

@ausi do you know a simple way to get the ICU version via PHP? (So that I don't have to Google 😉)

@ausi
Copy link
Member Author

ausi commented Feb 5, 2018

This should work: https://github.com/symfony/requirements-checker/blob/931997643fb512026241c7360c613bc1e61ed9cf/src/SymfonyRequirements.php#L283-L301

@ausi ausi mentioned this issue Feb 5, 2018
Closed
@fritzmg
Copy link
Collaborator

fritzmg commented Feb 8, 2018

On my system I get a version number of 57.1. Is that plausible?

@ausi
Copy link
Member Author

ausi commented Feb 8, 2018

Yes, that’s plausible. ICU changed the version numbering after 4.8.
They released: …, 4.2, 4.4, 4.6, 4.8, 49, 50, 51,…

@fritzmg
Copy link
Collaborator

fritzmg commented Feb 8, 2018

weird ;). Ok - see #139

@fritzmg fritzmg closed this as completed Feb 8, 2018
This was referenced Feb 18, 2018
Merged
Merged
leofeyer pushed a commit to contao/core-bundle that referenced this issue Feb 20, 2018
@fritzmg @leofeyer
Require aus/slug-generator ^1.0.1 (see #1375).
8e1509c 
Description
-----------

* #1352
* ausi/slug-generator#9
* contao/check#136

Commits
-------

9ffb818 require aus/slug-generator ^1.0.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ausi @fritzmg