Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Update the DEPRECATED.md file #741

Closed
wants to merge 2 commits into from
Closed

[RFC] Update the DEPRECATED.md file #741

wants to merge 2 commits into from

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Mar 28, 2017

I simply took the exact same wording from the trigger_error method here.

It would be useful to provide some examples - however PHP files do not seem to work there currently (#740).

Copy link
Member

@leofeyer leofeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems incomplete to me. There is also an initconfig.php file and a dcaconfig.php file, which are both deprecated, too. Shouldn't we add them all?

@fritzmg
Copy link
Contributor Author

fritzmg commented Apr 19, 2017

Agreed.

Am I right in assuming that any DCA changes should be done via app/Resources/contao/dca?

Not sure what to write about the initconfig.php though, other than it being deprecated.

@leofeyer
Copy link
Member

Symfony provides a lot of useful events that can be used instead of the initconfig.php file.

@fritzmg
Copy link
Contributor Author

fritzmg commented Apr 19, 2017

Do you have a suitable example? I cannot think of a proper use-case for the initconfig.php right now anymore. I sometimes put things in there that could be done in the dcaconfig.php as well - but I chose to do it in the initconfig.php since it is only executed once.

@aschempp
Copy link
Member

As far as I remember there is no Contao framework initialization event, but kernel.request might be used in most of the places for example.

@leofeyer leofeyer changed the title Update DEPRECATED.md with langconfig.php information. [WIP] Update DEPRECATED.md with langconfig.php information. Apr 28, 2017
@leofeyer leofeyer changed the title [WIP] Update DEPRECATED.md with langconfig.php information. [WIP] Update the DEPRECATED.md file Apr 28, 2017
@fritzmg
Copy link
Contributor Author

fritzmg commented Jun 9, 2017

I have updated the PR.

@fritzmg fritzmg changed the title [WIP] Update the DEPRECATED.md file [RFC] Update the DEPRECATED.md file Jun 9, 2017
leofeyer pushed a commit that referenced this pull request Jun 12, 2017
@leofeyer leofeyer added this to the 4.4.0 milestone Jun 12, 2017
@leofeyer
Copy link
Member

Merged in aae0a69.

@leofeyer leofeyer closed this Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants