Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.php not working #800

Merged
merged 1 commit into from
May 16, 2017
Merged

install.php not working #800

merged 1 commit into from
May 16, 2017

Conversation

xchs
Copy link
Contributor

@xchs xchs commented Apr 28, 2017

This adds the new/old route to the Contao install tool.

…o install tool

This adds the new/old route to the Contao install tool.
@leofeyer leofeyer added the bug label Apr 28, 2017
@leofeyer leofeyer added this to the 4.3.10 milestone Apr 28, 2017
@aschempp
Copy link
Member

This should be merged into develop afaik, in 4.3 the install.php is still necessary.

@leofeyer
Copy link
Member

No, it is not (at least not in the standard edition). And using the install.php entry point is currently broken in Contao 4.3, so /contao/install is in fact the only way to install Contao 4.3.

@aschempp
Copy link
Member

aschempp commented Apr 30, 2017 via email

@leofeyer
Copy link
Member

Not if you install the standard edition via Composer, which I guess is what everyone using the standard edition does.

@xchs
Copy link
Contributor Author

xchs commented Apr 30, 2017

As far as I know it is not necessary in the managed edition

I'm using the ME and it IS actually necessary to open the Contao install tool via /contao/install. Otherwise you get an error.

@aschempp
Copy link
Member

aschempp commented Apr 30, 2017 via email

@leofeyer
Copy link
Member

Feel free to create a PR if you really thing that it is important – because I don't.

@leofeyer leofeyer changed the title Incomplete installation exception message: Fix the route to the Contao install tool install.php not working May 3, 2017
@fritzmg
Copy link
Contributor

fritzmg commented May 9, 2017

This generates quite some confusion in the forum currently, since people are of course trying to open /install.php and do not know about the /contao/install route.

@aschempp
Copy link
Member

contao/manager-bundle@4d2babb is probably the best solution, maybe that should be merged in the next hotfix instead of develop @leofeyer ?

@leofeyer
Copy link
Member

@aschempp You can merge it in whatever branch you want. 😄

@m-vo
Copy link
Member

m-vo commented May 10, 2017

Btw.: the hint on the 'incomplete installation' error screen still points the user to /install.php. Might be better to change it to /contao/install.

https://github.com/contao/core-bundle/blob/master/src/Resources/contao/languages/en/exception.xlf#L51

@xchs
Copy link
Contributor Author

xchs commented May 10, 2017

Btw.: the hint on the 'incomplete installation' error screen still points the user to /install.php. Might be better to change it to /contao/install.

This is exactly what this PR was made for.

@aschempp
Copy link
Member

Added in 4.3.10: contao/manager-bundle@d8c9389

@leofeyer
Copy link
Member

See contao/managed-edition#7.

@leofeyer leofeyer closed this May 16, 2017
@leofeyer leofeyer changed the base branch from master to hotfix/4.3.10 May 16, 2017 10:43
@leofeyer leofeyer reopened this May 16, 2017
@leofeyer leofeyer merged commit 15ba1a0 into contao:hotfix/4.3.10 May 16, 2017
@xchs xchs deleted the patch-1 branch May 16, 2017 11:44
@leofeyer leofeyer modified the milestones: 4.3.10, 4.3 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants