change sections field to blob #862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschempp
approved these changes
Jun 4, 2017
ausi
approved these changes
Jun 4, 2017
There was a problem hiding this comment.
When we merge this, contao/installation-bundle#55 should get merged too.
|
Merged in 4cd899e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes contao/core#8722. Due to the new section wizard the limit of 1022 characters (on MyISAM) for the sections field will be reached much sooner. Thus, depending on the length of section names, you would be limited to a small number of sections. The limit is probably even smaller on InnoDB. If you go past that limit, invalid serialized data will be saved into the field.
This PR changes the field type to
blob, which is used for other fields with similar wizards as well.