Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Bug in file RepositoryManager.php? #8422

Closed
AppChecker opened this issue Jul 28, 2016 · 3 comments
Closed

Bug in file RepositoryManager.php? #8422

AppChecker opened this issue Jul 28, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@AppChecker
Copy link

Hello.

In method RepositoryManager::upgrade (RepositoryManager.php line 378):
($ext->version != $ext->upd_version || $ext->upd_build != $ext->upd_build)

$ext->upd_build is compared with itself.

May be it should be:
($ext->version != $ext->upd_version || $ext->build != $ext->upd_build)

This possible defect found by AppChecker

@discordier
Copy link
Contributor

Nice catch.

This means "build updates" will not get correctly handled (unless they have a version bump)...
They are shown in the correct state in the list, see line 1308.
Definitely worth fixing though.

@discordier
Copy link
Contributor

Update: This only affects the display string of the current action.
It will incorrectly show "validating extension xy" instead of "upgrading extension xy".
It will pull the files correctly though.

@leofeyer leofeyer added this to the 3.5.16 milestone Jul 28, 2016
@leofeyer leofeyer self-assigned this Aug 2, 2016
@leofeyer
Copy link
Member

leofeyer commented Aug 2, 2016

Fixed in 8b00896.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants