Implemented new picker #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
pushed a commit
that referenced
this pull request
Jun 14, 2021
Description ----------- Alternative approach for response context as discussed in Core team call. I guess there's no point in explaining it all here - I'll just document the final iteration once everything is done in the Contao dev docs ^^ Commits ------- 205dafc7 Reworked response context concept 786b50ca Merge branch '4.x' into feature/response-context-rework 4d1cf189 CS d2151bb4 Fixed tests aae10917 Implemented removing existing services and added support for interfaces 0a83cbe4 Added psalm docs 5f27ffce Make HtmlHeadBag final 5e75e386 CS 950e9bbe Also consider parent classes as aliases fbe8206c Going back to a regular array and removed the remove() method 41b1c60f Added support for lazy services 8a35bc96 Fixed tests 0d7f8d93 CS Co-authored-by: Leo Feyer <github@contao.org> 5b9706c4 Added failing test to show class issue d37a2237 Merge pull request #4 from aschempp/feature/response-context-rework Added failing test to show class issue f0a1f353 Removed irrelevant assertion 1d29c95c Fixed tests 6399cc78 Cleanup 12556327 Fixed phpstan 6a1eebc4 CS e90daf48 Added failing test to show alias being overridden a5c95893 Merge pull request #5 from aschempp/feature/response-context-rework Added failing test to show alias being overridden 1cb74c7a Fixed tests 84af804d Removed leftover 62cb0af1 CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see contao/core-bundle#950