Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMS-5380: create_upload fixes #949

Merged
merged 1 commit into from
Jan 22, 2025
Merged

HMS-5380: create_upload fixes #949

merged 1 commit into from
Jan 22, 2025
+12 −5

Conversation

xbhouse
Copy link
Contributor

@xbhouse xbhouse commented Jan 22, 2025

Summary

Fixes some issues when creating an upload:

  • changes artifact href to be a string instead of null if empty (this is blocking IQE from calling this api)
  • rejects request if chunk_size is 0

Testing steps

  1. Artifact href should be set to an empty string if it doesn't exist
  2. Request should be rejected if chunk size is 0 or less

@xbhouse xbhouse marked this pull request as ready for review January 22, 2025 16:42
@jlsherrill
Copy link
Member

https://issues.redhat.com/browse/HMS-5380

@mayurilahane
Copy link
Contributor

not facing the issue now and was able to create the upload

image

@mayurilahane
Copy link
Contributor

When chunk size is "0" it is giving error as expected

image

@mayurilahane
Copy link
Contributor

ACK

@mayurilahane mayurilahane merged commit 5a7601d into content-services:main Jan 22, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrewgdewar Andrewgdewar Andrewgdewar approved these changes

Assignees
No one assigned
Labels
qe-testing-needed Ready for QE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xbhouse @jlsherrill @mayurilahane @Andrewgdewar