HMS-5197: Fixes List snapshot being disabled for read only users (#407)

* HMS-5197: Fixes List snapshot being disabled for read only users * Update lint
content-services · Jan 10, 2025 · 0785455 · 0785455
1 parent 89e4826
commit 0785455
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 30 deletions.
diff --git a/src/Pages/Repositories/ContentListTable/ContentListTable.tsx b/src/Pages/Repositories/ContentListTable/ContentListTable.tsx
@@ -303,22 +303,26 @@ const ContentListTable = () => {
             ]
           : []
         : [
-            {
-              isDisabled: actionTakingPlace || rowData?.status === 'Pending',
-              title: 'Edit',
-              onClick: () => {
-                navigate(`${rowData.uuid}/${EDIT_ROUTE}`);
-              },
-            },
-            ...(rowData.origin === ContentOrigin.UPLOAD
+            ...(rbac?.repoWrite
               ? [
                   {
                     isDisabled: actionTakingPlace || rowData?.status === 'Pending',
-                    title: 'Upload content',
+                    title: 'Edit',
                     onClick: () => {
-                      navigate(`${rowData.uuid}/${UPLOAD_ROUTE}`);
+                      navigate(`${rowData.uuid}/${EDIT_ROUTE}`);
                     },
                   },
+                  ...(rowData.origin === ContentOrigin.UPLOAD
+                    ? [
+                        {
+                          isDisabled: actionTakingPlace || rowData?.status === 'Pending',
+                          title: 'Upload content',
+                          onClick: () => {
+                            navigate(`${rowData.uuid}/${UPLOAD_ROUTE}`);
+                          },
+                        },
+                      ]
+                    : []),
                 ]
               : []),
             ...(features?.snapshots?.accessible
@@ -330,7 +334,7 @@ const ContentListTable = () => {
                       navigate(`${rowData.uuid}/snapshots`);
                     },
                   },
-                  ...(rowData.origin !== ContentOrigin.UPLOAD
+                  ...(rbac?.repoWrite && rowData.origin !== ContentOrigin.UPLOAD
                     ? [
                         {
                           id: 'actions-column-snapshot',
@@ -358,7 +362,7 @@ const ContentListTable = () => {
                     : []),
                 ]
               : []),
-            ...(!rowData?.snapshot
+            ...(rbac?.repoWrite && !rowData?.snapshot
               ? [
                   {
                     isDisabled: actionTakingPlace || rowData?.status == 'Pending',
@@ -368,11 +372,15 @@ const ContentListTable = () => {
                   },
                 ]
               : []),
-            { isSeparator: true },
-            {
-              title: 'Delete',
-              onClick: () => navigate(`${DELETE_ROUTE}?repoUUID=${rowData.uuid}`),
-            },
+            ...(rbac?.repoWrite
+              ? [
+                  { isSeparator: true },
+                  {
+                    title: 'Delete',
+                    onClick: () => navigate(`${DELETE_ROUTE}?repoUUID=${rowData.uuid}`),
+                  },
+                ]
+              : []),
           ],
     [actionTakingPlace, checkedRepositories, isRedHatRepository],
   );
@@ -630,15 +638,11 @@ const ContentListTable = () => {
                           <Hide hide={!rowActions(rowData)?.length}>
                             <Td isActionCell>
                               <ConditionalTooltip
-                                content={
-                                  rowData?.status == 'Pending'
-                                    ? showPendingTooltip(
-                                        rowData?.last_snapshot_task?.status,
-                                        rowData.status,
-                                      )
-                                    : 'You do not have the required permissions to perform this action.'
-                                }
-                                show={!isRedHatRepository && !rbac?.repoWrite}
+                                content={showPendingTooltip(
+                                  rowData?.last_snapshot_task?.status,
+                                  rowData.status,
+                                )}
+                                show={!isRedHatRepository && rowData?.status === 'Pending'}
                                 setDisabled
                               >
                                 <ActionsColumn items={rowActions(rowData)} />

diff --git a/src/Pages/Repositories/ContentListTable/components/SnapshotListModal/SnapshotListModal.tsx b/src/Pages/Repositories/ContentListTable/components/SnapshotListModal/SnapshotListModal.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable quotes */
 import {
   Button,
   Flex,

diff --git a/src/components/SharedTables/AdvisoriesTable/index.tsx b/src/components/SharedTables/AdvisoriesTable/index.tsx
@@ -124,7 +124,7 @@ export default function AdvisoriesTable({
               </Tr>
             </Thead>
           </Hide>
-          {[...new Map(errataList.map(e => [e.errata_id, e])).values()].map(
+          {[...new Map(errataList.map((e) => [e.errata_id, e])).values()].map(
             (
               {
                 errata_id,

diff --git a/src/middleware/AppContext.tsx b/src/middleware/AppContext.tsx
@@ -14,8 +14,16 @@ import { useFetchSubscriptionsQuery } from 'services/Subscriptions/SubscriptionQ
 const getRegistry = _getRegistry as unknown as () => { register: ({ notifications }) => void };
 const { appname } = PackageJson.insights;
 
+// Add permissions here
+export enum RbacPermissions {
+  'repoRead', // If the user doesn't have this permission, they won't see the app, it is thus presumed true.
+  'repoWrite',
+  'templateWrite',
+  'templateRead',
+}
+
 export interface AppContextInterface {
-  rbac?: Record<string, boolean>;
+  rbac?: Record<keyof typeof RbacPermissions, boolean>;
   features: Features | null;
   isFetchingPermissions: boolean;
   subscriptions?: Subscriptions;
@@ -29,7 +37,9 @@ export interface AppContextInterface {
 export const AppContext = createContext({} as AppContextInterface);
 
 export const ContextProvider = ({ children }: { children: ReactNode }) => {
-  const [rbac, setRbac] = useState<Record<string, boolean> | undefined>(undefined);
+  const [rbac, setRbac] = useState<Record<keyof typeof RbacPermissions, boolean> | undefined>(
+    undefined,
+  );
   const [zeroState, setZeroState] = useState(true);
   const [features, setFeatures] = useState<Features | null>(null);
   const chrome = useChrome();