Fixes 2938: Add Errata tab to snapshot details

[Andrewgdewar]

Summary

• Adds a query to retrieve snapshot errata
• Adds an Errata tab to SnapshotDetails modal to list snapshot errata
• Supports filtering by name / synopsis, type, and severity
• Dependent on these PRs: backend, tang

Testing steps

• Add a repository with package errata and let it snapshot
• Click View all snapshots from the kebab on the Repositories page
• Click the Errata count to route to the Errata (Advisories) tab in the SnapshotDetails modal
• You should see all the errata for this snapshot displayed, with additional info for each errata displayed when clicking the expandable icon
• Filtering on name / synopsis, type, severity should only display errata with those filters

[jlsherrill]

https://issues.redhat.com/browse/HMS-2938

[swadeley]

/retest

[swadeley]

/retest

[swadeley]

Hi

I added repo:
https://jlsherrill.fedorapeople.org/fake-repos/needed-errata/

I clicked kebab, View all snapshots, clicked on the errata count "4",
"Snapshot detail" table was displayed but the lines were blank.

Table closed and the follow error was displayed:

Unable to find errata with the given UUID.
Bad Request

[swadeley]

/retest

[swadeley]

/retest

[xbhouse]

sorry just seeing this @swadeley. i wonder if the errors you're seeing are because the backend requires a new tang release. the tang PR will likely need to be merged in first before this can be tested properly, otherwise you'd need to reference a local clone of that tang PR in the backend

[Andrewgdewar]

✅ Ack on the code changes from me!
Feel free to ack this if you are good with the other changes @xbhouse!
Thanks for the help 🙇‍♂️

[rverdile]

The JIRA card says to include a link to the advisory page in the description, but I don't see it here. Should that be added or has the requirement changed?

[xbhouse]

cc @Andrewgdewar, similar question as above

[jlsherrill]

we might need some funny logic that checks if the errata starts with RH and add a link if so

[swadeley]

/retest

[swadeley]

/retest

[swadeley]

/retest

[swadeley]

Hi

looks good:

[xbhouse]

ack on @Andrewgdewar's code changes!

[jlsherrill]

I would make the default sort be done in descending order of date (so most recent errata first). Thats generally what users are more interested in.

[rverdile]

I agree with justin's comment, otherwise looks good to me

[jlsherrill]

Checking an epel errata, theres some formatting issues, for example:

[jlsherrill]

otherwise everything else looks great!

[xbhouse]

oh that doesn't look good at all :) there's no formatting being done on the description right now, i'll see what i can do there. which repo was that @jlsherrill ?

EDIT: i see it's epel9, no other errata in repos i've checked have a description with a changelog like that :/ i'm not sure how best to handle that

[xbhouse]

for the sorting on date, i think we'd have to make a change in the api to support that. i can open a bug? correct me if i'm wrong @Andrewgdewar

[jlsherrill]

We probably just need to adjust the default order here: https://github.com/content-services/tang/blob/main/pkg/tangy/rpm.go#L313

as right now its not configurable, which i think is okay for now

[jlsherrill]

and yeah, that can be a followup ticket

[xbhouse]

sort order changed thanks to @Andrewgdewar ! and here's that epel errata description with the latest push @jlsherrill. thoughts?

[swadeley]

/retest

[swadeley]

/retest