Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManifestSummary/Tooltip/Popover accessibility #145

Open
majornista opened this issue Mar 5, 2024 · 0 comments
Open

ManifestSummary/Tooltip/Popover accessibility #145

majornista opened this issue Mar 5, 2024 · 0 comments

Comments

@majornista
Copy link

majornista commented Mar 5, 2024 •
edited
Loading

Tooltip component used in ManifestSummary should:

  1. Trigger should be keyboard accessible as a button.
  2. Trigger should be labeled by the Tooltip and the header.
  3. Popover for Tooltip should expand on focus and close on blur.
  4. Popover should hide with Escape key and toggle on Trigger click.
  5. Fix text color contrast for --cai-secondary-color.
  6. Fix color contrast for --cai-icon-fill
  7. Add focus outline color and outline-offset to Tooltip button and View More
  8. Use <section> with aria-labelledby for PanelSection.
  9. Add role="heading" and a heading level for the .heading-text element within PanelSection
  10. Add role="img" and appropriate aria-label for each of the Icons
majornista added a commit to majornista/c2pa-js that referenced this issue Mar 5, 2024
@majornista
fix(contentauth#145): ManifestSummary/Tooltip/Popover accessibility
34026a8 
Tooltip component used in ManifestSummary should:

1. Trigger should be keyboard accessible as a button.
2. Trigger should be labeled by the Tooltip and the header.
3. Popover for Tooltip should expand on focus and close on blur.
4. Popover should hide with Escape key and toggle on Trigger click.
5. Fix text color contrast for --cai-secondary-color.
6. Fix color contrast for  --cai-icon-fill
7. Add focus outline color and outline-offset to Tooltip button and View More
8. Use `<section>` with aria-labelledby for PanelSection.
9. Add role="heading" and a heading level for the .heading-text element within PanelSection
10. Add role="img" and appropriate aria-label for each of the Icons
majornista added a commit to majornista/c2pa-js that referenced this issue Jul 12, 2024
@majornista
fix(contentauth#145): ManifestSummary/Tooltip/Popover accessibility
d6f2741 
Implement keyboard accessibility for Popover trigger and make it more generic, so that a user only needs to worry about an aria-label for the cai-indicator, rather than the expand/collapse behavior as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@majornista