-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hosted app actions for sap [EXT-5612] #8603
feat: add hosted app actions for sap [EXT-5612] #8603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this test handler and .spec file for it to just have a test that is passing in this folder. We can remove this down the road.
|
||
return { | ||
status: 'Success', | ||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll see this in a few places in these app actions. I just opted to ignore ts errors for now since these will need to be refactored to work anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file: I renamed the frontend app and removed all of the deploy scripts; those are now in the top level package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something we've used in other apps and it's useful for testing app actions
59cc866
to
dbc16a7
Compare
* feat: reorganize app to introduce haa * chore: add more template files to app actions and remove deploy scripts from frontend
* feat: reorganize app to introduce haa * chore: add more template files to app actions and remove deploy scripts from frontend
* feat: reorganize app to introduce haa * chore: add more template files to app actions and remove deploy scripts from frontend
Purpose
We will use hosted app actions to make api calls with the AIR header for the SAP AIR app. This PR introduces a lot of the boilerplate around hosted app actions.
Approach
Updated the SAP app to follow the project structure and boilerplate used in the MS Teams and Vercel apps. See this PR as an example for Vercel: #6769
Specifically, here is a summary of the changes:
frontend
directoryvite.config
to support parent project build outDir locationapp-actions
directoryTesting steps
I confirmed that I could successfully build the frontend and actions and deployed to both staging apps. Confirmed that the app config page and field locations are rendering for both staging apps. I am not able to see products in the Dialog, but that's also a problem I am seeing on our feature branch.
Breaking Changes
Dependencies and/or References
Deployment