-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: taxonomy endpoints [GROOT-1273] #2315
Conversation
caf50d4
to
ddcf93f
Compare
f895081
to
04978a2
Compare
cab1337
to
6dc3398
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome 👏 I know lots of people will be excited to see these go out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Looking good on the surface though. Would love someone who is more familiar with the repo to take a closer look.
| ({ conceptScheme?: string; query?: string } & BasicCursorPaginationOptions & | ||
Omit<PaginationQueryOptions, 'skip'>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't BasicCursorPaginationOptions
already extend Omit<PaginationQueryOptions, 'skip'>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice 🚀
🎉 This PR is included in version 11.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds all endpoints for the new
Concept
andConceptScheme
entityDocumentation