Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: taxonomy endpoints [GROOT-1273] #2315

Merged
merged 27 commits into from
Jul 11, 2024
Merged

feat: taxonomy endpoints [GROOT-1273] #2315

merged 27 commits into from
Jul 11, 2024

Conversation

momenzadehvida
Copy link
Contributor

@momenzadehvida momenzadehvida commented Jun 12, 2024

Adds all endpoints for the new Concept and ConceptScheme entity

Documentation

@momenzadehvida momenzadehvida requested a review from a team as a code owner June 12, 2024 14:43
@momenzadehvida momenzadehvida marked this pull request as draft June 12, 2024 14:43
@marcolink marcolink force-pushed the GROOT-1273 branch 3 times, most recently from caf50d4 to ddcf93f Compare June 13, 2024 14:58
@marcolink marcolink changed the title feat: [GROOT-1273] Add create concept endpoint feat: concept endpoints [GROOT-1273] Jun 17, 2024
@marcolink marcolink force-pushed the GROOT-1273 branch 2 times, most recently from f895081 to 04978a2 Compare June 17, 2024 13:10
@marcolink marcolink marked this pull request as ready for review June 17, 2024 14:26
@marcolink marcolink force-pushed the GROOT-1273 branch 2 times, most recently from cab1337 to 6dc3398 Compare June 17, 2024 15:35
Copy link
Contributor

@jjolton-contentful jjolton-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👏 I know lots of people will be excited to see these go out!

@momenzadehvida momenzadehvida changed the title feat: concept endpoints [GROOT-1273] feat: taxonomy endpoints [GROOT-1273] Jul 3, 2024
@momenzadehvida momenzadehvida marked this pull request as draft July 4, 2024 13:56
@momenzadehvida momenzadehvida marked this pull request as ready for review July 5, 2024 14:07
Copy link

@AdrianLThomas AdrianLThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Looking good on the surface though. Would love someone who is more familiar with the repo to take a closer look.

test/integration/taxonomy-integration.ts Show resolved Hide resolved
test/integration/taxonomy-integration.ts Show resolved Hide resolved
lib/adapters/REST/endpoints/concept.ts Outdated Show resolved Hide resolved
Comment on lines +2043 to +2044
| ({ conceptScheme?: string; query?: string } & BasicCursorPaginationOptions &
Omit<PaginationQueryOptions, 'skip'>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't BasicCursorPaginationOptions already extend Omit<PaginationQueryOptions, 'skip'>?

maxcheremisin
maxcheremisin previously approved these changes Jul 9, 2024
Copy link
Member

@maxcheremisin maxcheremisin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice 🚀

@momenzadehvida momenzadehvida merged commit 5b63545 into master Jul 11, 2024
6 checks passed
@momenzadehvida momenzadehvida deleted the GROOT-1273 branch July 11, 2024 12:46
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants