Merge pull request #484 from contentful/feat/replace-node-apis

feat: replace qs node API with URLSearchParams web api
contentful · Jul 3, 2024 · d8bcbb8 · d8bcbb8
2 parents 706d7b6 + 8020f4e
commit d8bcbb8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -51,8 +51,7 @@
     "fast-copy": "^2.1.7",
     "lodash.isplainobject": "^4.0.6",
     "lodash.isstring": "^4.0.1",
-    "p-throttle": "^4.1.1",
-    "qs": "^6.11.2"
+    "p-throttle": "^4.1.1"
   },
   "devDependencies": {
     "@babel/cli": "^7.12.8",

diff --git a/src/create-http-client.ts b/src/create-http-client.ts
@@ -2,7 +2,6 @@ import { AxiosRequestHeaders } from 'axios'
 import type { AxiosStatic } from 'axios'
 import copy from 'fast-copy'
 import asyncToken from './async-token'
-import qs from 'qs'
 
 import rateLimitRetry from './rate-limit'
 import rateLimitThrottle from './rate-limit-throttle'
@@ -97,9 +96,10 @@ export default function createHttpClient(
     maxBodyLength: config.maxBodyLength,
     paramsSerializer: {
       serialize: (params) => {
-        return qs.stringify(params)
+        return params ? new URLSearchParams(params).toString() : ''
       },
     },
+
     // Contentful
     logHandler: config.logHandler,
     responseLogger: config.responseLogger,