fix(number-editor): use "text" input that syncs numeric value when valid #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to browser implementations React is unable to fully control inputs of `type="number"`. This commit changes `NumberEditor` to `type="text"` to avoid these issues. We keep a local string input value that we then convert to a number when it's actually valid.
denkristoffer
requested review from
gui-santos and
bgutsol
and removed request for
a team
|
✔️ Deploy Preview for contentful-field-editors ready! 🔨 Explore the source changes: 691a876 🔍 Inspect the deploy log: https://app.netlify.com/sites/contentful-field-editors/deploys/620a67e49851630007009022 😎 Browse the preview: https://deploy-preview-1020--contentful-field-editors.netlify.app |
bgutsol
reviewed
Feb 14, 2022
bgutsol
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to browser implementations, React is unable to fully control inputs of
type="number": facebook/react#6556This commit changes
NumberEditortotype="text"to avoid these issues. We keep a local string input value that we then convert to a number when it's actually valid.