New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WIP add template gha for code reviews [] #2479

Closed

whitelisab wants to merge 33 commits into main from feat/gha-code-review

Contributor

whitelisab commented Aug 7, 2024

Purpose

Approach

Testing steps

Breaking Changes

Dependencies and/or References

Deployment


          add template gha for code reviews

5aae8f7

whitelisab requested a review from a team as a code owner

August 7, 2024 16:17

whitelisab changed the title ~~WIP: add template gha for code reviews []~~ feat: WIP add template gha for code reviews []

whitelisab added 2 commits

August 7, 2024 10:21


          add feat branch target

3d2fb97


          change target

f286133

Contributor

github-actions bot commented Aug 7, 2024

Thank you for your pull request! We will review it shortly.

github-actions bot added the needs review label


          add check for new app dir

Contributor

github-actions bot commented Aug 7, 2024

Thank you for your pull request! We will review it shortly.


          add new dir for testing

c4afd51

Contributor

github-actions bot commented Aug 7, 2024

Thank you for your pull request! We will review it shortly.


          change dir name

01bc3e8

Contributor

github-actions bot commented Aug 7, 2024

Thank you for your pull request! We will review it shortly.


          check for new apps not files

202543a

Contributor

github-actions bot commented Aug 7, 2024

Thank you for your pull request! We will review it shortly.

whitelisab added 6 commits

August 7, 2024 10:56


          create script file

15c0cf2


          change path to script

a15e54e


          change path again

0c7c03e


          log pwd

43da030


          add checkout

ae5e340


          change location

fd1f025

Contributor

github-actions bot commented Aug 7, 2024

Thank you for your pull request! We will review it shortly.

whitelisab force-pushed the feat/gha-code-review branch 2 times, most recently from 42510c4 to 3244eeb Compare

August 7, 2024 17:27

Contributor

github-actions bot commented Aug 7, 2024

😡
License check failed

github-actions bot added the needs work label


          add licence check and validators

db8361d

whitelisab force-pushed the feat/gha-code-review branch from 3244eeb to db8361d Compare

August 7, 2024 17:32

Contributor

github-actions bot commented Aug 7, 2024

😡
License check failed


          refactor: new-app-review

c65b6c5

whitelisab force-pushed the feat/gha-code-review branch from de60a7a to f164e99 Compare

August 7, 2024 21:15

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies

whitelisab force-pushed the feat/gha-code-review branch from f164e99 to 87fd82f Compare

August 7, 2024 21:17

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies

whitelisab force-pushed the feat/gha-code-review branch from 87fd82f to e6c8846 Compare

August 7, 2024 21:19

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies

whitelisab force-pushed the feat/gha-code-review branch from e6c8846 to e055145 Compare

August 7, 2024 21:20

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies

whitelisab force-pushed the feat/gha-code-review branch from e055145 to 57380c6 Compare

August 7, 2024 21:22

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies


          add warnings and dependency outdated check

2dc40df

whitelisab force-pushed the feat/gha-code-review branch from 57380c6 to 2dc40df Compare

August 7, 2024 21:24

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies

1 similar comment

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies


          use spawn instead of exec for outdated check

07aa636

whitelisab force-pushed the feat/gha-code-review branch from 78463c8 to 07aa636 Compare

August 7, 2024 21:28

Contributor

github-actions bot commented Aug 7, 2024

😡
Failed to check for outdated dependencies

Contributor

github-actions bot commented Aug 7, 2024 •

edited by whitelisab

Loading

Please acknowledge the following warnings:

The following dependencies are outdated:
{
"eslint": {
"current": "8.57.0",
"wanted": "8.57.0",
"latest": "9.8.0",
"dependent": "my-new-test-app",
"location": "/home/runner/work/marketplace-partner-apps/marketplace-partner-apps/apps/my-new-test-app/node_modules/eslint"
}
}

github-actions bot added Ready for review and removed Further development recommended labels

whitelisab force-pushed the feat/gha-code-review branch from e15c358 to d78ee5d Compare

August 7, 2024 21:35

Contributor

github-actions bot commented Aug 7, 2024

Please acknowledge the following warnings:

The following dependencies are outdated:
{
"eslint": {
"current": "8.57.0",
"wanted": "8.57.0",
"latest": "9.8.0",
"dependent": "my-new-test-app",
"location": "/home/runner/work/marketplace-partner-apps/marketplace-partner-apps/apps/my-new-test-app/node_modules/eslint"
}
}


          fix dependencies check

02bc7c3

whitelisab force-pushed the feat/gha-code-review branch from d78ee5d to 02bc7c3 Compare

August 7, 2024 21:37

Contributor

github-actions bot commented Aug 7, 2024

Please acknowledge the following warnings:

The following dependencies are outdated:
eslint


          undo permissions

08522c5

Contributor

github-actions bot commented Aug 7, 2024

Please acknowledge the following warnings:

The following dependencies are outdated:
eslint

whitelisab added 2 commits

August 7, 2024 15:41


          adjust target branch

84e5651


          delete sample app

d7d9d09

whitelisab closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for review