feat: add v1 node types constraints #279
Conversation
| /** | ||
| * Node types before `tables` implementation | ||
| */ | ||
| export const V1_NODE_TYPES = [ |
There was a problem hiding this comment.
Question: should we add this as a schema constraint or node type? I thought this would be more suitable here by looking at the code.
There was a problem hiding this comment.
This is probably the most appropriate place for it even though it's not properly speaking a "schema" constraint. If anything I would push for the file name to be genericized to something like constraints.ts (not important for this PR).
| /** | ||
| * Node types before `tables` implementation | ||
| */ | ||
| export const V1_NODE_TYPES = [ |
There was a problem hiding this comment.
This is probably the most appropriate place for it even though it's not properly speaking a "schema" constraint. If anything I would push for the file name to be genericized to something like constraints.ts (not important for this PR).
| @@ -96,3 +97,29 @@ export const CONTAINERS = { | |||
| [BLOCKS.TABLE_CELL]: [BLOCKS.PARAGRAPH], | |||
| [BLOCKS.TABLE_HEADER_CELL]: [BLOCKS.PARAGRAPH], | |||
| }; | |||
|
|
|||
| /** | |||
| * Node types before `tables` implementation | |||
There was a problem hiding this comment.
nit: "implementation" a bit technical, maybe "release"?
cezarsmpio
force-pushed
the
SHE-509/v1-node-types
branch
from
66dd9a3
to
db97672
Compare
No description provided.