Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rich-text-types): resolve generated JSON schemas #294

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

z0al
Copy link
Member

@z0al z0al commented Dec 10, 2021

Using the new validateRichTextDocument fails due to require('./generated/{nodeType}.json') unable to resolve the file.

Before:

dist/
  lib/
    schemas/
      generated/
      index.js // importing the helper directly works
  rich-text-types.es5.js // a single bundle of the whole source code. It fails to locate ./generated

After:

dist/
  schemas/
    generated/
    index.js // importing the helper directly still works
  index.js // now calls schemas/generated/index.js since the code no longer bundled together.

@z0al z0al enabled auto-merge (squash) December 10, 2021 13:22
@z0al z0al merged commit 1e5b4c4 into master Dec 10, 2021
@z0al z0al deleted the fix-relative-require branch December 10, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants