Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix:** Deal with trailing spaces in getInitials #1365

Merged
merged 1 commit into from
Jan 19, 2021
Merged

**Fix:** Deal with trailing spaces in getInitials #1365

merged 1 commit into from
Jan 19, 2021

Conversation

fabien0102
Copy link
Contributor

Summary

getInitials utils was throwing an error with trailing spaces.

Related issue

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@fabien0102 fabien0102 self-assigned this Jan 19, 2021
@fabien0102 fabien0102 requested a review from mpotomin January 19, 2021 13:21
@fabien0102 fabien0102 merged commit 2c0b840 into master Jan 19, 2021
@fabien0102 fabien0102 deleted the fix-get-initials-v2 branch January 19, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpotomin mpotomin mpotomin approved these changes

Assignees

@fabien0102 fabien0102

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabien0102 @mpotomin