'make tar' to use docker compiled assets #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisplo
changed the title
chrisplo
changed the title
unclejack
reviewed
Oct 16, 2017
Makefile
Outdated
|
|
||
| # build tarball | ||
| tar: compile-with-docker | ||
| docker run --rm netplugin-build:$(NETPLUGIN_CONTAINER_TAG) \ |
There was a problem hiding this comment.
Please use docker cp to copy build artifacts.
There was a problem hiding this comment.
there is no container to target docker cp
There was a problem hiding this comment.
switching to docker create + docker cp + docker rm
chrisplo
changed the title
chrisplo
changed the title
chrisplo
force-pushed
the
tar_update
branch
2 times, most recently
from
b2fe667
to
86cb2c8
Compare
chrisplo
changed the title
Beacuse of start/stop of a VM, a tar build can take 4 minutes. When using a docker container, when previously compiled only needs 10s (30s if netplugin src updated) Add target to export tar from container build to local directory Signed-off-by: Chris Plock <chrisplo@cisco.com>
|
build PR |
|
this (and compile-with-docker) works in VM (docker 1.12) as well as desktop (docker 17.09), though without a private registry to cache things like the golang layer, the startup cost of compiling in docker on a fresh VM is large, better to run this target locally. |
dseevr
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make taris primarily used for release, it is much faster to use compile-with-docker locally than spawn a VM to run the build.Signed-off-by: Chris Plock chrisplo@cisco.com