Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contiv network is not deleted when docker network is deleted #1029

Merged
merged 8 commits into from
Oct 31, 2017

Commits on Oct 22, 2017

  1. Contiv network is not deleted when docker network is deleted

    Steps to reproduce:
    1. Create a docker network with docker network CLI
    2. Ensure docker network and contiv network are created (docker network ls and netctl network ls)
    3. Remove docker network.
    4. Check docker network ls, docker network is deleted
    5. Check netctl networ ls, contiv network is still test.
    
    The root cause is due to the dockernetworkstate mapping is planned to delete after
    contiv network is delete. However, the determination of contiv network deletion is
    determined by the existance of the dockernetworkstate. Thefore, if the state is still
    there, the contiv network will be unable to delete.
    
    The fix is to delete the dockernetworkstate before proceed to contiv network deletion
    
    Signed-off-by: Kahou Lei kalei@cisco.com
    kahou82 committed Oct 22, 2017
    Configuration menu
    Copy the full SHA
    97ca836 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. Print out error

    kahou82 committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    d0eddc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2017

  1. Configuration menu
    Copy the full SHA
    0f1772f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37a3b82 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2017

  1. Add more testing

    kahou82 committed Oct 28, 2017
    Configuration menu
    Copy the full SHA
    5f77471 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6e8f5b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2017

  1. Refactor base on comments

    kahou82 committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    5661ee9 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2017

  1. Add more check in unit test.

    Take out return statement when docker network is not there.
    kahou82 committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    f4208d8 View commit details
    Browse the repository at this point in the history