-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contiv network is not deleted when docker network is deleted #1029
Merged
Commits on Oct 22, 2017
-
Contiv network is not deleted when docker network is deleted
Steps to reproduce: 1. Create a docker network with docker network CLI 2. Ensure docker network and contiv network are created (docker network ls and netctl network ls) 3. Remove docker network. 4. Check docker network ls, docker network is deleted 5. Check netctl networ ls, contiv network is still test. The root cause is due to the dockernetworkstate mapping is planned to delete after contiv network is delete. However, the determination of contiv network deletion is determined by the existance of the dockernetworkstate. Thefore, if the state is still there, the contiv network will be unable to delete. The fix is to delete the dockernetworkstate before proceed to contiv network deletion Signed-off-by: Kahou Lei kalei@cisco.com
Configuration menu - View commit details
-
Copy full SHA for 97ca836 - Browse repository at this point
Copy the full SHA 97ca836View commit details
Commits on Oct 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d0eddc9 - Browse repository at this point
Copy the full SHA d0eddc9View commit details
Commits on Oct 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 0f1772f - Browse repository at this point
Copy the full SHA 0f1772fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37a3b82 - Browse repository at this point
Copy the full SHA 37a3b82View commit details
Commits on Oct 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5f77471 - Browse repository at this point
Copy the full SHA 5f77471View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6e8f5b - Browse repository at this point
Copy the full SHA f6e8f5bView commit details
Commits on Oct 29, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5661ee9 - Browse repository at this point
Copy the full SHA 5661ee9View commit details
Commits on Oct 30, 2017
-
Take out return statement when docker network is not there.
Configuration menu - View commit details
-
Copy full SHA for f4208d8 - Browse repository at this point
Copy the full SHA f4208d8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.