Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contour replies to all XTGETTCAP with FFFFFF #582

Closed
dankamongmen opened this issue Jan 10, 2022 · 3 comments · Fixed by #584
Closed

contour replies to all XTGETTCAP with FFFFFF #582

dankamongmen opened this issue Jan 10, 2022 · 3 comments · Fixed by #584
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)

Comments

@dankamongmen
Copy link
Contributor

Contour Terminal version

0.3.0-unreleased-master-f764fb6f

Installer source

Github: source code cloned

Operating System

Debian Linux Unstable

Architecture

x86-64

Other Software

notcurses 3.0.5-prerelease

Steps to reproduce

echo -e '\eP+q687061\e\'

Expected Behavior

:0+r^[\ if hpa is unsupported
:1+r687061=5c455b2569257031256447^[\ (or something similar) if it is

Actual Behavior

:1+r687061=FFFFFFFF^[\

Additional notes

this seems to be returned for all XTGETTCAP requests.

this now causes a problem, because notcurses 3.0.5 will be pulling hpa's definition from XTGETTCAP if it's defined there. technically, FF would be an invalid byte, since there should not be any bigger than 7F, so i can ignore this and throw it out. you probably want to fix it, though.
@dankamongmen dankamongmen added the feature-request User requested features label Jan 10, 2022
@christianparpart
Copy link
Member

Oh sorry @dankamongmen . I will have that fixed by tonight.

@christianparpart christianparpart added bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API) and removed feature-request User requested features labels Jan 11, 2022
christianparpart added a commit that referenced this issue Jan 11, 2022
@christianparpart
[terminal] Screen: Fixes XTGETTCAP response to string requests and in…
8465d4d 
…valid numeric requests. Closes #582
@christianparpart christianparpart mentioned this issue Jan 11, 2022
Merged
@christianparpart
Copy link
Member

I had tcap generally unit tested. but apparently not enough. I'll merge the fix ASAP.

@christianparpart
Copy link
Member

"commented yesterday" ... WHAT? And I just noticed this afternoon? Sorry....

christianparpart added a commit that referenced this issue Jan 11, 2022
@christianparpart
[terminal] Screen: Fixes XTGETTCAP response to string requests and in…
115721f 
…valid numeric requests. Closes #582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Milestone
No milestone
2 participants
@christianparpart @dankamongmen