-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected internal error if specifying invalid command line option #647
Comments
@kumattau I just wanted to mention, the version can be taken via |
Overall improvements and fix to #647
@christianparpart |
The error is to appear in the window. That part is right. But it should be a user targeted error message, and not an internal error. I was sure I fixed that and checked it locally. I will revisit (As soon as I am awake enough) :) |
…ms when the reuqested shell cannot be spawned (#647).
…ms when the reuqested shell cannot be spawned (contour-terminal#647).
Contour Terminal version
0.3.0.198
Installer source
GitHub: release page
Operating System
Ubuntu Linux 20.04
Architecture
x86-64
Other Software
No response
Steps to reproduce
Invalid option is specified. For example,
Expected Behavior
Error message is shown without internal error.
At the same time, it is better to output how to display help or the help itself.
Actual Behavior
Error message is shown with internal error.
Additional notes
I noticed this when I tried to display the version with -V.
I think application should validate user's specified options and shows only appropriate message without internal error if the options are invalid.
This problem occurs in the current latest commit 0cf97cb
The text was updated successfully, but these errors were encountered: