Unexpected internal error if specifying invalid command line option

[kumattau]

Contour Terminal version

0.3.0.198

Installer source

GitHub: release page

Operating System

Ubuntu Linux 20.04

Architecture

x86-64

Other Software

No response

Steps to reproduce

Invalid option is specified. For example,

contour -V

Expected Behavior

Error message is shown without internal error.
At the same time, it is better to output how to display help or the help itself.

Actual Behavior

Error message is shown with internal error.

Additional notes

I noticed this when I tried to display the version with -V.
I think application should validate user's specified options and shows only appropriate message without internal error if the options are invalid.

This problem occurs in the current latest commit 0cf97cb

[christianparpart]

@kumattau I just wanted to mention, the version can be taken via contour version and help via contour help. We do support longopt-style syntax, so one might want to write contour --version and contour --help, too. Short-opts are currently not supported. On purpose actually. But that may change. I'm not hard'ly opinionated here. :)

[kumattau]

@christianparpart
Thank you for the usage.
My point was not about usage, but that internal errors should not be reported when options are incorrectly specified.
I tried 720303e but there does not appear to be a fix for this yet.
Of course, it depends on the application's error handling policy, so I respects the answer if current error handing is in accordance with the specification of this software.

[christianparpart]

The error is to appear in the window. That part is right. But it should be a user targeted error message, and not an internal error. I was sure I fixed that and checked it locally. I will revisit (As soon as I am awake enough) :)