-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Run a quicker clang-tidy
for verification in the CI automatically
#1026
Conversation
You can see an example execution of the "Checks" workflow here: https://github.com/whisperity/Contour/actions/runs/4145252988/jobs/7169368342 The ways of how it is triggered is a bit weird. |
@whisperity oopsi. there's a merce conflict in |
src/.clang-tidy
Outdated
# This is a *verification* check. The configuration **MUST** be kept in sync | ||
# with .github/codechecker/config-verify.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sure I can create a CI check that validates that both are in sync. once this one is merged, i can take care of that (I did it for a few other things already, too. :) )
61796c4
to
d6af9fe
Compare
42d3385
to
2c71ab3
Compare
0203094
to
d87eb90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added src/contour/ to the skipfile.txt until the QML branch (#761) is merged.
a659f34
to
52fecb0
Compare
.github/codechecker/skipfile.txt
Outdated
-*/_deps/sources/termbench-pro-*/* | ||
-*/_deps/sources/* | ||
-*/_deps/* | ||
-*/src/contour/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This effectively disables static analysis for the project as a whole, no?
Signed-off-by: Christian Parpart <christian@parpart.family>
… branch is merged. Signed-off-by: Christian Parpart <christian@parpart.family>
Signed-off-by: Christian Parpart <christian@parpart.family>
I close it, we have github action for clang-tidy now |
Some checks are implemented in Clang-Tidy that can be used to verify style-like requirements that pure syntax-based systems, such as Clang-Format is not capable of.
Adds a new CI job using the CodeChecker action that runs only these verification checkers (and thus quicker than the full-blown static analysis workflow) and explicitly breaks the build if the style things do not match.
(Due to technical reasons with Clang-Tidy configuration, unfortunately, some minor duplication needs to be done between
.clang-tidy
and the CodeChecker config file.)