-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds VT sequence DECSSCLS and properly handle DECSCLM #1212
Conversation
0b9c96a
to
c9edd73
Compare
71cbe6d
to
df604cd
Compare
Signed-off-by: Christian Parpart <christian@parpart.family>
df604cd
to
a799c29
Compare
if (value.IsScalar()) | ||
{ | ||
auto time = value.as<unsigned>(); | ||
if (time < 10 || time > 2000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can add =
as well here
1, // 0 | ||
2, // 1 | ||
9, // 2 | defined by spec to be 18 lines per second | ||
13, // 3 | ||
18, // 4 | defined by spec to be 18 lines per second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a big deal, but if you are revisiting this code, I'd suggest maybe using 3, 6, 9, 12, and 18 for these first 5 settings. That way you'd also be able to select the original speeds used on some of the early DEC terminals: 6 for the VT1xx/VT2xx models; 3, 6, and 12 for the VT340; and you still have 9 and 18 in their standard positions for the VT5xx models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I better take care of it now, before I forget: #1231 :)
Closes #1204