Adds VT sequence DECSSCLS and properly handle DECSCLM #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VT: Backend
christianparpart
force-pushed
the
improvement/slow-scroll-mode
branch
5 times, most recently
from
0b9c96a
to
c9edd73
Compare
christianparpart
force-pushed
the
improvement/slow-scroll-mode
branch
5 times, most recently
from
71cbe6d
to
df604cd
Compare
Signed-off-by: Christian Parpart <christian@parpart.family>
christianparpart
force-pushed
the
improvement/slow-scroll-mode
branch
from
df604cd
to
a799c29
Compare
Yaraslaut
reviewed
Oct 3, 2023
| if (value.IsScalar()) | ||
| { | ||
| auto time = value.as<unsigned>(); | ||
| if (time < 10 || time > 2000) |
There was a problem hiding this comment.
maybe we can add = as well here
j4james
reviewed
Oct 3, 2023
Comment on lines
+852
to
+856
| 1, // 0 | ||
| 2, // 1 | ||
| 9, // 2 | defined by spec to be 18 lines per second | ||
| 13, // 3 | ||
| 18, // 4 | defined by spec to be 18 lines per second |
There was a problem hiding this comment.
This is not a big deal, but if you are revisiting this code, I'd suggest maybe using 3, 6, 9, 12, and 18 for these first 5 settings. That way you'd also be able to select the original speeds used on some of the early DEC terminals: 6 for the VT1xx/VT2xx models; 3, 6, and 12 for the VT340; and you still have 9 and 18 in their standard positions for the VT5xx models.
There was a problem hiding this comment.
I better take care of it now, before I forget: #1231 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1204