Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of terminal tabs #1584

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Implementation of terminal tabs #1584

merged 1 commit into from
Oct 6, 2024

Conversation

Yaraslaut
Copy link
Member

@Yaraslaut Yaraslaut commented Aug 4, 2024

Closes #90

Checklist

  • documentation
  • create new tab
  • switch to tab on the left
  • switch to tab on the right
  • switch to tab by index
  • close tab
  • ensure window sizing is not affected by tab spawning or tab switching

@github-actions github-actions bot added the frontend Contour Terminal Emulator (GUI frontend) label Aug 4, 2024
@Yaraslaut Yaraslaut changed the title Features/tabs Implementation of terminal tabs Aug 4, 2024
}
onCurrentIndexChanged: {
print("currentIndex changed to", currentIndex)
terminalSessions.setSession(currentIndex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow. THAT is a really nice take on tabs! :)

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Sep 26, 2024
@Yaraslaut Yaraslaut marked this pull request as ready for review September 26, 2024 17:11
@Yaraslaut Yaraslaut force-pushed the features/tabs branch 3 times, most recently from 530f1cb to 675a53d Compare September 29, 2024 14:53
@christianparpart christianparpart force-pushed the features/tabs branch 3 times, most recently from 7fbd25e to 68e6cca Compare October 1, 2024 06:20
@Yaraslaut Yaraslaut force-pushed the features/tabs branch 5 times, most recently from 9a6db4f to 3a8db2f Compare October 4, 2024 17:05
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2024
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Yaraslaut.

@christianparpart christianparpart merged commit a28a967 into master Oct 6, 2024
31 checks passed
@christianparpart christianparpart deleted the features/tabs branch October 6, 2024 11:28
@denisgolius
Copy link

Hey @christianparpart , when to expect the new release? :)

@Yaraslaut
Copy link
Member Author

Hey @christianparpart , when to expect the new release? :)

hi @denisgolius, if you want to try out tabs asap, you can build from master, otherwise it will take some time until we have some confidence that tabs are somewhat stable, and we want to add some customization into it as well before the next release.
At the moment we are not planning to create new release, so most likely later this year

@denisgolius
Copy link

Hey @christianparpart , when to expect the new release? :)

hi @denisgolius, if you want to try out tabs asap, you can build from master, otherwise it will take some time until we have some confidence that tabs are somewhat stable, and we want to add some customization into it as well before the next release. At the moment we are not planning to create new release, so most likely later this year

Ok, thanks!

@christianparpart
Copy link
Member

Thanks for your interest. Before a bad experience may make people unhappy, we want to make sure that this impactful change is not causing any troubles. A few are known (pending PR) and one is left out to be fixed apart from what @Yaraslaut also already said, please bear with us, and submit bug tickets whenever you find something and we will try our best to improve based on the feedback you guys are giving us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend Contour Terminal Emulator (GUI frontend) VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: terminal tabs
3 participants