Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vi-modifier viW / oiW / yiW as well as B and W (white space delimited motions) #1609

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix vi-modifier viW / oiW / yiW as well as B and W (white space delimited motions) #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cfbf4f
[vtbackend] Fixes vi-mode motions like `viW`, `yiW`, `oiW` as well as…
christianparpart Sep 30, 2024
f13fc00
metainfo.xml cleanup
christianparpart Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,9 @@
<release version="0.5.1" urgency="medium" type="development">
<description>
<ul>
<li>Port to C++20's `std::format()` (#1598)</li>
<li>Fixes vi-mode motions like `viW`, `yiW`, `oiW` as well as `B` and `W`</li>
<li>Enable support for Unicode version 16.0.0 (#1606)</li>
<li>Port to C++20's `std::format()` (#1598)</li>
<li>Drop support for Ubuntu 23.10 and older. In order to have less burdain of maintencne, we only support the latest LTS of Ubuntu, which currently is 24.04 (#1607)</li>
<li>Fix rendered backend loading from config</li>
</ul>
Expand Down
3 changes: 2 additions & 1 deletion src/vtbackend/Line.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ class Line
return unbox<size_t>(column) >= trivialBuffer().text.size()
|| trivialBuffer().text[column.as<size_t>()] == 0x20;
}
return inflatedBuffer().at(unbox<size_t>(column)).empty();
auto const& cell = inflatedBuffer().at(unbox<size_t>(column));
return cell.empty() || (cell.codepointCount() == 1 && cell.codepoint(0) == 0x20);
}

[[nodiscard]] uint8_t cellWidthAt(ColumnOffset column) const noexcept
Expand Down
Loading